Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate grid xDomain change #896

Merged

Conversation

mtraynham
Copy link
Contributor

Crossfilter always provides every row, even if the measure value is 0. When not using Crossfilter, this will almost never be the case.

This check ensures that the xAxis is updated if the previous domain length is not equal to that of the new domain.

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone May 24, 2015
@gordonwoodhull
Copy link
Contributor

This logic is getting really hairy. I wonder if there would be any risk to just always rescaling. Are there cases where we actually want the _xUnitCount not to change when the domain has changed?

@mtraynham
Copy link
Contributor Author

The only reason not to may be performance, but I believe that has fairly minimal overhead anyway.

@gordonwoodhull
Copy link
Contributor

Moved that hairy logic to a function, and compare elements by string value for good measure (to avoid date problems). Thanks @mtraynham!

@gordonwoodhull gordonwoodhull merged commit 77b3fc3 into dc-js:master Jun 9, 2015
@mtraynham mtraynham deleted the coordinate_grid_mixin_domain_changed branch June 10, 2015 19:44
@mtraynham
Copy link
Contributor Author

Thanks Gordon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants