Paired Row Chart and Row Chart useRightYAxis #943
Conversation
|
Coooool. One could implement #510 bidirectional row chart with this. |
|
I am working on a Paired Row Chart like https://reference.wolfram.com/language/ref/PairedBarChart.html if that is what you mean by a bidirectional row chart. This is a precursor to getting the paired row chart (or whatever you want to call it) to work. |
|
I have just noticed that the animation when rendering is still going from right to left. If you hold off for a bit I can get that to work from left to right as well. |
|
Yeah exactly, see the link to #510 above. Usually used for gender vs age distribution. Thanks for the row example, that's been missing. I'm going to have to wait for tests (nudge, or write them myself), so no rush... |
… and adding in tests
|
I have fixed up the animation for row charts that are right aligned and also added tests. How does it all look? |
|
@gordonwoodhull I have implemented the paired row chart, included examples and tests. I feel it is a little hacky by having two sub row charts, but all in all it works great for me. I had to change the row chart slightly to get it to work. Take a look at the example for how it works. |
ruhley
changed the title
Conflicts: spec/helpers/fixtures.js spec/row-chart-spec.js src/row-chart.js web/examples/index.html web/examples/row.html
Conflicts: dc.js.map dc.min.js dc.min.js.map
|
Ooops, usually the best practice is to create a feature branch when contributing a PR. This has a ton of other changes in it now. I think I can sort through and find the changes that are relevant to this feature. Sorry for the extreme lag in merging this! It's hard to find the time for a careful review. |
|
Yea, I realised that I probably should have done that a bit late, which is why I updated the changelog, so that anyone could find the commits for each feature easier. |
|
Yes, that is very helpful! Probably what needs to happen next is for someone (could be me or anyone with decent git fu) to create a PR with just those changes. I have to review changes mostly independently. |
|
Replaced by #1068, with just the relevant commits. |
No description provided.