Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Passing individual values" issue #15

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

mizok
Copy link
Contributor

@mizok mizok commented Jan 15, 2022

Hey man, I got another pull request for you, and I also helped fix your README, too.
It is about the issue "Passing individual values", I found that the old method you mentioned in README using querystring is not working(seems to be something wrong with your entry path)

And since Node.js had marked the querystring as legacy API in version 14.x, and recommended using URLSearchParams, I think we should give the old method an upgrade .

I am still using webpack loader inline for this problem, but I change the old method for a little bit (You can check it).

If you have any problem, feel free to contact me using twitter : D

Cheers 👍

fix #11

README.md Outdated Show resolved Hide resolved
src/types.ts Outdated
}
},
templatePath?:string
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Options type that can be imported from ejs to define the templateEjsLoaderOption.

Also, how about describing the whole WebpackPluggingTemplateCustomizerConfig in index.ts?
Currently types.ts is just describing the types that are not exported from webpack, so
I would like to put template-ejs-loader's own types in index.ts.

@dc7290
Copy link
Owner

dc7290 commented Jan 15, 2022

@mizok

You've helped me again!
Thank you for suggesting a new way to do the old way!

There are a few things I would like to see corrected, please.

@mizok
Copy link
Contributor Author

mizok commented Jan 15, 2022

Sure, I will change this ASAP.

src/types.ts Outdated
}
},
templatePath?:string
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Options type that can be imported from ejs to define the templateEjsLoaderOption.

Also, how about describing the whole WebpackPluggingTemplateCustomizerConfig in index.ts?
Currently types.ts is just describing the types that are not exported from webpack, so
I would like to put template-ejs-loader's own types in index.ts.

@mizok
Copy link
Contributor Author

mizok commented Jan 15, 2022

BTW it is named htmlWebpackPluginTemplateCustomizerConfig, not WebpackPluggingTemplateCustomizerConfig, or are you more intended for this name (WebpackPluggingTemplateCustomizerConfig)?

I named this way bc I thought it is only for htmlWebpackPlugin, since this loader has that dependency.

src/index.ts Outdated Show resolved Hide resolved
@mizok
Copy link
Contributor Author

mizok commented Jan 15, 2022

ok~

@dc7290
Copy link
Owner

dc7290 commented Jan 15, 2022

BTW it is named htmlWebpackPluginTemplateCustomizerConfig, not WebpackPluggingTemplateCustomizerConfig, or are you intended for this name (WebpackPluggingTemplateCustomizerConfig)?

I named this way bc I thought it is only for htmlWebpackPlugin, since this loader has this dependency.

This is a mistake.
You can leave it as it is now!

@dc7290
Copy link
Owner

dc7290 commented Jan 15, 2022

@mizok

Thanks!
Now we have a way to pass individual values!

@dc7290 dc7290 merged commit 0528f06 into dc7290:main Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Passing individual values" config output errors
2 participants