-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "Passing individual values" issue #15
Conversation
src/types.ts
Outdated
} | ||
}, | ||
templatePath?:string | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the Options
type that can be imported from ejs
to define the templateEjsLoaderOption
.
Also, how about describing the whole WebpackPluggingTemplateCustomizerConfig
in index.ts
?
Currently types.ts
is just describing the types that are not exported from webpack
, so
I would like to put template-ejs-loader
's own types in index.ts
.
You've helped me again! There are a few things I would like to see corrected, please. |
Sure, I will change this ASAP. |
src/types.ts
Outdated
} | ||
}, | ||
templatePath?:string | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the Options
type that can be imported from ejs
to define the templateEjsLoaderOption
.
Also, how about describing the whole WebpackPluggingTemplateCustomizerConfig
in index.ts
?
Currently types.ts
is just describing the types that are not exported from webpack
, so
I would like to put template-ejs-loader
's own types in index.ts
.
BTW it is named I named this way bc I thought it is only for |
ok~ |
This is a mistake. |
Thanks! |
Hey man, I got another pull request for you, and I also helped fix your README, too.
It is about the issue "Passing individual values", I found that the old method you mentioned in README using
querystring
is not working(seems to be something wrong with your entry path)And since
Node.js
had marked thequerystring
as legacy API in version 14.x, and recommended usingURLSearchParams
, I think we should give the old method an upgrade .I am still using webpack loader inline for this problem, but I change the old method for a little bit (You can check it).
If you have any problem, feel free to contact me using twitter : D
Cheers 👍
fix #11