Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morped modules-scala-console to scala code #36

Merged
merged 1 commit into from
Apr 5, 2012
Merged

Morped modules-scala-console to scala code #36

merged 1 commit into from
Apr 5, 2012

Conversation

og0815
Copy link
Collaborator

@og0815 og0815 commented Mar 25, 2012

To get warmed up, I morphed the scala-console module to scala code.
I keept the Action and the TopComponent in Java, because I intend to convert them to nb7xx style with annotations, removing the need for the xml files.
(Netbeans Annotations at Scala code seam to be ignored)

@dcaoyuan
Copy link
Owner

dcaoyuan commented Apr 5, 2012

(Netbeans Annotations at Scala code seam to be ignored)
Yes. That's why I keep use xml instead of nb7xx annotations.

Welcome to board.

@dcaoyuan dcaoyuan closed this Apr 5, 2012
@dcaoyuan dcaoyuan reopened this Apr 5, 2012
dcaoyuan added a commit that referenced this pull request Apr 5, 2012
Morped modules-scala-console to scala code
@dcaoyuan dcaoyuan merged commit 54b1b22 into dcaoyuan:master Apr 5, 2012
@dcaoyuan
Copy link
Owner

dcaoyuan commented Apr 5, 2012

Hi,

I merged your code. Please give me your public key, I'll add you as the
developer.

-Caoyuan

On Sun, Mar 25, 2012 at 10:14 PM, Oliver Günther <
reply@reply.github.com

wrote:

To get warmed up, I morphed the scala-console module to scala code.
I keept the Action and the TopComponent in Java, because I intend to
convert them to nb7xx style with annotations, removing the need for the xml
files.
(Netbeans Annotations at Scala code seam to be ignored)

You can merge this Pull Request by running:

git pull https://github.com/og0815/nbscala master

Or you can view, comment on it, or merge it online at:

#36

-- Commit Summary --

  • Morphed the Scala Console to Scala

-- File Changes --

M README.md (154)
M pom.xml (532)
M scala.console/pom.xml (232)
M
scala.console/src/main/java/org/netbeans/modules/scala/console/ScalaConsoleTopComponent.java
(985)
D
scala.console/src/main/java/org/netbeans/modules/scala/console/ScalaExecution.java
(368)
D
scala.console/src/main/java/org/netbeans/modules/scala/console/readline/FileNameCompletor.java
(137)
D
scala.console/src/main/java/org/netbeans/modules/scala/console/readline/History.java
(255)
D
scala.console/src/main/java/org/netbeans/modules/scala/console/readline/TextAreaReadline.java
(354)
A
scala.console/src/main/scala/org/netbeans/modules/scala/console/ScalaExecution.scala
(349)
R
scala.console/src/main/scala/org/netbeans/modules/scala/console/readline/Completor.scala
(15)
R
scala.console/src/main/scala/org/netbeans/modules/scala/console/readline/ConsoleLineReader.scala
(36)
A
scala.console/src/main/scala/org/netbeans/modules/scala/console/readline/FileNameCompletor.scala
(124)
A
scala.console/src/main/scala/org/netbeans/modules/scala/console/readline/History.scala
(216)
A
scala.console/src/main/scala/org/netbeans/modules/scala/console/readline/TextAreaReadline.scala
(294)

-- Patch Links --

https://github.com/dcaoyuan/nbscala/pull/36.patch
https://github.com/dcaoyuan/nbscala/pull/36.diff


Reply to this email directly or view it on GitHub:
#36

@jglick
Copy link

jglick commented Apr 5, 2012

Regarding NetBeans layer-generating annotations in Scala source: not sure if it would even be possible for scalac to run JSR 269-compliant processors. For groovyc I think it would be possible, as I commented in GROOVY-3361, but that is a source language much closer to Java, with mostly similar constructs.

@dcaoyuan
Copy link
Owner

dcaoyuan commented Apr 5, 2012

Is the main task that a partial mapper which maps annotations at scalal AST
to java? if so, I can write it.

-Caoyuan

On Thu, Apr 5, 2012 at 10:03 PM, jglick <
reply@reply.github.com

wrote:

Regarding NetBeans layer-generating annotations in Scala source: not sure
if it would even be possible for scalac to run JSR 269-compliant
processors. For groovyc I think it would be possible, as I commented in
GROOVY-3361, but that is a
source language much closer to Java, with mostly similar constructs.


Reply to this email directly or view it on GitHub:
#36 (comment)

@jglick
Copy link

jglick commented Apr 5, 2012

No, it is more than that; an implementation of javax.lang.model and javax.annotation.processing would be needed. Parts of the Scala AST which do not clearly correspond to Java language constructs (with comparable runtime behavior at the JVM level) would have to be omitted. Whether the result would really work naturally, I do not know.

@dcaoyuan
Copy link
Owner

dcaoyuan commented Apr 5, 2012

Thanks for the information, I'll think about it.

-Caoyuan

On Fri, Apr 6, 2012 at 1:50 AM, jglick <
reply@reply.github.com

wrote:

No, it is more than that; an implementation of javax.lang.model and
javax.annotation.processing would be needed. Parts of the Scala AST which
do not clearly correspond to Java language constructs (with comparable
runtime behavior at the JVM level) would have to be omitted. Whether the
result would really work naturally, I do not know.


Reply to this email directly or view it on GitHub:
#36 (comment)

@og0815
Copy link
Collaborator Author

og0815 commented Apr 9, 2012

For the time being, I would suggest, to keep the annotated parts in java. Most of the time these are user interfaces. And I don't think anyone is interested in hand crafting these.

@dcaoyuan
Copy link
Owner

Agree.

-Caoyuan

On Tue, Apr 10, 2012 at 12:55 AM, Oliver Günther <
reply@reply.github.com

wrote:

For the time being, I would suggest, to keep the annotated parts in java.
Most of the time these are user interfaces. And I don't think anyone is
interested in hand crafting these.


Reply to this email directly or view it on GitHub:
#36 (comment)

dcaoyuan added a commit that referenced this pull request Nov 13, 2012
Morped modules-scala-console to scala code
akochnev added a commit to akochnev/ak_nbscala that referenced this pull request May 22, 2015
dcaoyuan added a commit that referenced this pull request May 23, 2015
Fixed GitHub issue #36 : refactor display labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants