Add tests for SeasonGrouper API (PR #9524) #40
Conversation
|
Amazing! I am so happy to see this. Are you planning to push more tests or shall I merge? |
Happy to contribute. I'll see if I can come up with more tests then I'll mark it ready for review. |
|
As an aside, if you see scope for logic or code improvements, those suggestions are welcome too. I tried to look at xcdats implementation but couldn't follow it. |
tomvothecoder
changed the title
| @pytest.mark.xfail | ||
| @pytest.mark.parametrize("calendar", _ALL_CALENDARS) | ||
| def test_season_grouper_with_months_spanning_calendar_year_using_previous_year( | ||
| self, calendar | ||
| ): | ||
| # NOTE: This feature is not implemented yet. Maybe it can be a | ||
| # parameter to the `SeasonGrouper` API (e.g. `use_previous_year=True`). |
There was a problem hiding this comment.
Added this test marked with xfail. I will try to see how we can implement this feature with the SeasonGrouper in another PR. It probably involves more work with the groupby API itself since it uses months from the same year for a season.
|
Hey @dcherian this PR is ready for review and merge. If I have any logic or code improvements, I will open a separate PR or suggest them in pydata#9524. |
|
Thanks, this really helps! |
This PR adds tests for pydata#9524.