Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 ✨ #3310

Closed
wants to merge 8 commits into from
Closed

Webpack 4 ✨ #3310

wants to merge 8 commits into from

Conversation

brandonc
Copy link
Contributor

@brandonc brandonc commented Sep 21, 2018

I had some time last night to upgrade to Webpack 4. It's slightly faster, but doesn't offer any big advantages that I know of right now. If we migrate to babel 7, we can drop ts-loader since babel 7 can transpile typescript now. That could potentially knock 20s off our build time

Testing

npm start or npm run build-assets

Trade-offs

I don't know of any risks.

Dependencies

This branch is based on #3307

Run `npm start` with PROFILE_WEBPACK=1 in order to get some useful
output about how much time is being spent in each file type loader.
Decreases successive rebuild time be avoiding transpilation on unchanged modules.

Caches by default to node_modules/.cache/babel-loader. Disk utilization was 10MB.
ExtractTextPlugin was deprecated in Webpack 4 and replaced by this package
@brandonc brandonc mentioned this pull request Sep 21, 2018
@nLight nLight self-assigned this Sep 25, 2018
@nLight
Copy link
Contributor

nLight commented Sep 25, 2018

Awesome! Last time I tried that there was some major uglify issues I had to manually patch #3177

@Poltergeist
Copy link
Contributor

Can we solve the conflicts in the config files? Otherwise I like this direction.

@brandonc
Copy link
Contributor Author

I think I just need to reopen it after rebasing #3307

@brandonc brandonc closed this Sep 25, 2018
@brandonc brandonc mentioned this pull request Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants