-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 4 ✨ #3310
Closed
Closed
Webpack 4 ✨ #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `npm start` with PROFILE_WEBPACK=1 in order to get some useful output about how much time is being spent in each file type loader.
Decreases successive rebuild time be avoiding transpilation on unchanged modules. Caches by default to node_modules/.cache/babel-loader. Disk utilization was 10MB.
ExtractTextPlugin was deprecated in Webpack 4 and replaced by this package
Closed
brandonc
force-pushed
the
brandonc/webpack_perf
branch
from
September 25, 2018 02:04
d570496
to
fd4d977
Compare
Awesome! Last time I tried that there was some major uglify issues I had to manually patch #3177 |
Can we solve the conflicts in the config files? Otherwise I like this direction. |
I think I just need to reopen it after rebasing #3307 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some time last night to upgrade to Webpack 4. It's slightly faster, but doesn't offer any big advantages that I know of right now. If we migrate to babel 7, we can drop ts-loader since babel 7 can transpile typescript now. That could potentially knock 20s off our build time
Testing
npm start
ornpm run build-assets
Trade-offs
I don't know of any risks.
Dependencies
This branch is based on #3307