Add container ID tags to prometheus metrics #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLAndAddress was tightly coupled to the Kubernetes service discovery use case; it allowed an 'address' tag to be added to metrics to specify the k8s app in which metrics had originated. This commit broadens the struct so that it can contain any tag. This will clear the way to add a container ID to identify the Mesos task metric source.
philipnrmn
changed the title
philipnrmn
changed the title
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 5, 2019
* Refactor URLAndAddress to URLAndTags URLAndAddress was tightly coupled to the Kubernetes service discovery use case; it allowed an 'address' tag to be added to metrics to specify the k8s app in which metrics had originated. This commit broadens the struct so that it can contain any tag. This will clear the way to add a container ID to identify the Mesos task metric source. * Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 5, 2019
* Refactor URLAndAddress to URLAndTags URLAndAddress was tightly coupled to the Kubernetes service discovery use case; it allowed an 'address' tag to be added to metrics to specify the k8s app in which metrics had originated. This commit broadens the struct so that it can contain any tag. This will clear the way to add a container ID to identify the Mesos task metric source. * Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 6, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 6, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 6, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 6, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 6, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 11, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 11, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
branden
pushed a commit
to branden/telegraf
that referenced
this pull request
Feb 13, 2019
* Update container IDs to memorable values * Add method for extracting container id from task * Update tests with container IDs * Add container ID to metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds container IDs to metrics gathered from Mesos tasks by Prometheus. This allows
dcos_metadatato add metadata like task_id. This is also required for the DC/OS PR(dcos/dcos#3940) to pass.