Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Tests are failing #29

Closed
rfay opened this issue Sep 19, 2024 · 8 comments · Fixed by #30
Closed

Automated Tests are failing #29

rfay opened this issue Sep 19, 2024 · 8 comments · Fixed by #30
Assignees

Comments

@rfay
Copy link
Member

rfay commented Sep 19, 2024

Describe the bug

As of today, the automated tests are failing.

I re-ran them a couple of times, but they're failing on both HEAD and stable, so it's probably not something to do with DDEV.

I manually tried ddev get ddev/ddev-sqlsrv on gitpod and it worked OK, but the ddev restart did take forever. Maybe something has just slowed down...

@rfay
Copy link
Member Author

rfay commented Sep 19, 2024

Trying to run it manually in tmate/github actions shows a fatal error:

This program has encountered a fatal error and cannot continue running at Thu Sep 19 14:12:55 2024
The following diagnostic information is available:

         Reason: 0x00000001
         Signal: SIGABRT - Aborted (6)
          Stack:
                 IP               Function
                 ---------------- --------------------------------------
                 000055fbc43d955c <unknown>
                 000055fbc43d8fa2 <unknown>
                 000055fbc43d8541 <unknown>
                 00007fa8bdeec210 killpg+0x40
                 00007fa8bdeec18b gsignal+0xcb
                 00007fa8bdecb859 abort+0x12b
                 000055fbc4366ed2 <unknown>
        Process: 9 - sqlservr
         Thread: 101 (application thread 0x18c)
    Instance Id: 0187b18a-4619-41dc-bcf9-29366b21d0b3
       Crash Id: 3b30ef69-43ae-41fc-97f7-c1aeb70dded4

@rfay
Copy link
Member Author

rfay commented Sep 19, 2024

It looks like either github or MS has changed something. It may be worth trying to try some of the newer images in https://mcr.microsoft.com/en-us/product/mssql/server/tags ?

@robertoperuzzo could you take a look at this? Debugging using tmate is covered in https://github.com/ddev/ddev-addon-template?tab=readme-ov-file#how-to-debug-tests-github-actions

@rfay
Copy link
Member Author

rfay commented Sep 19, 2024

Current runner is ubuntu-latest, which currently means 22.04, see https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md. It was in fact updated Sept 16:

The release was just several hours ago, so this is probably the reason for the failure.

@robertoperuzzo
Copy link
Collaborator

Thank you @rfay for your report. I'm going to look at it in the next few days during the DrupalCon Europe.

@rfay
Copy link
Member Author

rfay commented Sep 23, 2024

Cool, thanks! We can take a look together if you need any help looking at it. Another project had trouble because of the new docker-compose in HEAD, but your trouble here is both stable and head, so I guess it's maybe github runner.

@robertoperuzzo robertoperuzzo self-assigned this Sep 26, 2024
@rfay
Copy link
Member Author

rfay commented Sep 26, 2024

@robertoperuzzo and I took a look at this, and

  • Inside the Github Actions runner, you can't even do a ddev start because the sqlsrv process hits a SIGABRT, perhaps due to a kernel issue.
  • On gitpod, ddev start works OK

Possible paths to figure something out:

  • Try all the possible runners provided by GitHub
  • Try some other versions of sqlsrv Docker images from MS

@robertoperuzzo robertoperuzzo linked a pull request Sep 26, 2024 that will close this issue
@robertoperuzzo
Copy link
Collaborator

@rfay I try to use the same Ubuntu version in both the action runner's and the sqlsrv images and it seems to works https://github.com/ddev/ddev-sqlsrv/actions/runs/11052477017?pr=30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants