Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow home directory additions in web container, fixes #926, fixes #1459 #1728

Merged
merged 6 commits into from
Jul 29, 2019

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 24, 2019

The Problem/Issue/Bug:

#926 requests a way to configure the user inside the web container (.bashrc, etc)
#1459 specifically requests a way to set the user's ~/.gitconfig as they apparently do commits inside the container

How this PR Solves The Problem:

Copy the contents of the project's .ddev/homeadditions into the containers ~/

Manual Testing Instructions:

mkdir -p  .ddev/homeadditions
touch .ddev/homeadditions/ITWORKED.txt
ddev start
ddev ssh
ls -al ~/

You should see your ITWORKED.txt

Try out some of the example usages in docs

Review docs.

Automated Testing Overview:

Hopefully existing tests would catch regressions.

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay added this to the v1.10 milestone Jul 24, 2019
@rfay rfay force-pushed the 20190724_container_homedir branch from 6eb34b3 to 2be274d Compare July 24, 2019 20:20
@rfay
Copy link
Member Author

rfay commented Jul 25, 2019

Current artifacts are at https://circleci.com/gh/drud/ddev/16195#artifacts/containers/0 - Would really love to have people try this out. It's a very simple approach, but should help the people that have requested these solutions. @unn @andrewfrench

@rfay rfay requested review from unn and andrewfrench July 25, 2019 13:06
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to create files in .ddev/homeadditions/ and have them appear at ~/ in the container, as shown with both the IT_WORKS.txt file as well as a .bash_aliases file that configures the container bash environment. This is pretty cool, and while I don't personally work from in the container, should really help those that do.

Copy link
Contributor

@unn unn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Testing steps followed and worked as expected.

@rfay rfay force-pushed the 20190724_container_homedir branch from bb4941b to bbd5ac5 Compare July 29, 2019 18:21
@rfay rfay merged commit 6b76de8 into ddev:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants