fix: Shorten the time before API call

[rfay]

The current 55 day timeout before we hit the API seems to be a little long, as GitHub warns before 55 days. We can shorten it, here to 45.

But I'm not sure why we don't just use 1 here instead, not sure it would do any harm to hit the API daily.

[julienloizelet]

Thanks for this PR.

I'd rather wait for answers on this time_elapsed value.

In the end, I think we could set "0" as the default entry (this should make one call each time).

[gautamkrishnar]

Thanks a lot for the PR and issue @rfay. Thanks for debugging. @julienloizelet 👍🏻.

This looks good to me to be used with my project. Some more docs changes are required on my project, I will make those myself. I will also make this default value in mine.

Update: released a version that uses this value as default: https://github.com/gautamkrishnar/keepalive-workflow/releases/tag/2.0.3

[julienloizelet]

@rfay ,
so now that we have all the answers, we have to decide.
Should we keep "45" in this PR or should we set "0" ?
In my opinion, "0" is a good move (if an user want to change, he still can as it is a configurable input).

With "0", the api call will be done on every run.

[rfay]

0 seems OK to me.

[julienloizelet]

As we discussed, we could set "0" here, as a default value.

To be consistent with keepalive original workflow, we should set the string "0" (and not the number 0) because the original workflow expects a string as input.

(In my opinion, it was an already an error to set 55 and not "55" as default value).

[julienloizelet]

Thanks.

I will merge and make a new release asap (tomorrow, I guess)

[rfay]

I'm not sure, but I think this may not have worked out right. I'm seeing test failures on stable (not latest) in a couple of repos, where the tests have obviously succeeded:

• https://github.com/justafish/ddev-drupal-core-dev/actions/runs/9213831558/job/25348604861?pr=33
• https://github.com/ddev/ddev-solr/actions/runs/9204758550

[julienloizelet]

I'm not sure, but I think this may not have worked out right. I'm seeing test failures on stable (not latest) in a couple of repos, where the tests have obviously succeeded:

* https://github.com/justafish/ddev-drupal-core-dev/actions/runs/9213831558/job/25348604861?pr=33

* https://github.com/ddev/ddev-solr/actions/runs/9204758550

Very strange, indeed: it appears to works well for most of the repos.

I've tried a couple of tests and all was successful.

For the solr repo, there is a permission issue; maybe it can explain the error.

For the ddev-drupal-core-dev repo, there is no obvious problem: I suspect a branch protection rule, or action permission settings, but, at least, there should be a more explicit error message in this case.

I'll ask @gautamkrishnar if he has any idea what might be the root cause.

[julienloizelet]

I've created an issue : gautamkrishnar/keepalive-workflow#42

Thanks