Skip to content

Commit

Permalink
support-resetting-warn_once-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: code indent should use tabs where possible
torvalds#124: FILE: kernel/panic.c:604:
+                        clear_warn_once_set,$

WARNING: please, no spaces at the start of a line
torvalds#124: FILE: kernel/panic.c:604:
+                        clear_warn_once_set,$

ERROR: code indent should use tabs where possible
torvalds#125: FILE: kernel/panic.c:605:
+^I^I        "%lld\n");$

WARNING: please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)
torvalds#135: FILE: kernel/panic.c:615:
+__initcall(register_warn_debugfs);

total: 2 errors, 2 warnings, 87 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/support-resetting-warn_once.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and hnaz committed Nov 11, 2017
1 parent ca88b42 commit 6dd5932
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions kernel/panic.c
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,8 @@ static int clear_warn_once_set(void *data, u64 val)

DEFINE_SIMPLE_ATTRIBUTE(clear_warn_once_fops,
NULL,
clear_warn_once_set,
"%lld\n");
clear_warn_once_set,
"%lld\n");

static __init int register_warn_debugfs(void)
{
Expand All @@ -612,7 +612,7 @@ static __init int register_warn_debugfs(void)
return 0;
}

__initcall(register_warn_debugfs);
device_initcall(register_warn_debugfs);
#endif

#ifdef CONFIG_CC_STACKPROTECTOR
Expand Down

0 comments on commit 6dd5932

Please sign in to comment.