Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detections.md to reference the correct yara rules directory #67

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

w8mej
Copy link
Contributor

@w8mej w8mej commented Nov 30, 2023

The current link results in a 404. The relative link to the yara detection directory fails as the yara detection library's parent (data) is located one folder up from this document's location, not in the current doc's directory.

The current link results in a 404.  The relative link to the yara detection directory fails as the yara detection library's parent (data) is located one folder up from this document's location, not in the current doc's directory.

Signed-off-by: John Menerick <coding@haxx.ninja>
@deadbits
Copy link
Owner

deadbits commented Dec 6, 2023

Good catch, thank you!

@deadbits deadbits merged commit 3e0cd0e into deadbits:main Dec 6, 2023
1 check passed
@deadbits deadbits self-assigned this Dec 6, 2023
@deadbits deadbits added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 6, 2023
@w8mej
Copy link
Contributor Author

w8mej commented Dec 7, 2023

Thank you for the positive feedback and for accepting the pull request! It's great to contribute to such an impactful project. Keep up the fantastic work on this project - it's making a real difference in the community!

@w8mej w8mej deleted the patch-1 branch December 7, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants