-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toml: move from toml to tomllib + tomli_w #395
Conversation
02b2d55
to
1554e5b
Compare
I'm unsure how my change triggered this. |
Oh very cool, thanks a lot for this! I'm also surprised by the pylint error since I have other actions using the same pylint/python version that did not raise that linting error. It seems it has been raised already, see pylint-dev/pylint#3132. I added pylint comments in 84bdd80 what should hopefully bypass those linting errors. Could you rebase? |
* toml is getting removed from distributions due to being generally unmaintained and not support the lastest TOML standard. * For parsing use tomllib which is included in python3.11 and tomli for earlier interpeter versions. * For writing use tomli-w. tomli-w.dump() expects bytes-like objects so work around it to keep compatability and minimize changes elsewhere. Signed-off-by: Alfred Wingate <parona@protonmail.com>
Something with tomli_w is cursed :P |
On an unrelated note ive gotten to minimize the issue with tests-ng/import-with-trans.s to the gnupg version. Something with behaviour changed between 2.2.41 and 2.4.2 which causes it to fail. Haven't further time on this. But if you update the ci container at some point in the future, it may then become an issue. |
Thanks. I have opened an issue at pylint with your example: pylint-dev/pylint#8930. |
Thanks, good point, I'll move away from |
@parona-source thanks again for your help on this! I'll release a new version ASAP. |
https://fedoraproject.org/wiki/Changes/DeprecatePythonToml
https://bugs.gentoo.org/878651
Ran the full test-ng test suite in Ubuntu container with python3.8 as its failing on my host machine for unrelated reasons in current HEAD. Haven't looked further on that. Pytest and toml.sh pass just fine.
Arch appears to be on python3.11 so it should just need tomli-w.