Split cargo-deadlinks and deadlinks into two binaries #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
force-pushed
the
deadlinks-bin
branch
2 times, most recently
from
b875b2c to
154ed75
Compare
jyn514
added
the
S-waiting-on-review
|
@jyn514 Yeah, I think |
hobofan
removed
the
S-waiting-on-review
jyn514
force-pushed
the
deadlinks-bin
branch
2 times, most recently
from
bb21d3e to
08ebaf8
Compare
- Expose public `walk_dir` function, which prints all missing files - `impl Clone for CheckContext` - Put cargo dependencies behind a feature gate - Switch from `Into` to `From` to help type inference
jyn514
force-pushed
the
deadlinks-bin
branch
from
a259a19 to
aaf773a
Compare
This shouldn't affect the end-user at all, it just makes things easier for development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
walk_dirfunction, which prints all missing filesimpl Clone for CheckContextIntotoFromto help type inferenceCloses #47.
r? @hobofan - what do you think? Does it make sense to expose
walk_dirpublicly? If not, I can move it intomod shared.