Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright headers #171

Merged
merged 21 commits into from
Mar 5, 2024
Merged

Update copyright headers #171

merged 21 commits into from
Mar 5, 2024

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Feb 23, 2024

No description provided.

@tamiko tamiko changed the title Update copyright header: advection_reaction_estimator, cdr, CeresFE Update copyright headers Feb 24, 2024
@tamiko tamiko force-pushed the annotate_source_1 branch 3 times, most recently from f062fd8 to 3d6d054 Compare February 24, 2024 00:33
@tamiko tamiko mentioned this pull request Feb 24, 2024
Merged
@tamiko
Copy link
Member Author

tamiko commented Feb 24, 2024 •
edited
Loading

@bangerth I think this change here is very important. It ensures that we correctly attribute every contribution to the respective authors in individual header and source files. This ensures that if someone else copies files out of the repository (to use in their own project) that authorship and license are spelled out.

tjhei
tjhei approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Would it make sense to add email address(es) of the main authors in the headers as well? Or too much effort? I think it makes sense to add them in the future at least to make it easier for users to get in touch.

@gassmoeller gassmoeller mentioned this pull request Mar 5, 2024
Merged
@tamiko
Copy link
Member Author

tamiko commented Mar 5, 2024

@tjhei We record all contributors with e-mail in doc/author so I figured just the name in the copyright header is enough.

@bangerth bangerth merged commit 7887add into dealii:master Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth approved these changes

@tjhei tjhei tjhei approved these changes

Assignees
No one assigned
Labels
Review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamiko @tjhei @bangerth