Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Web Store update -> lost all tabs #512

Closed
mcamou opened this issue Jun 5, 2017 · 106 comments
Closed

Chrome Web Store update -> lost all tabs #512

mcamou opened this issue Jun 5, 2017 · 106 comments

Comments

@mcamou
Copy link

mcamou commented Jun 5, 2017

I have installed The Great Suspender from the Chrome Web Store. From what I read here, automatic updates should be disabled, but... a few minutes ago it auto-updated and I lost >50 tabs :( I don't know if this can be fixed, but at least a warning when installing (and even in the "Tab suspended" screen) would be appreciated.

@0xC0FFEE
Copy link

0xC0FFEE commented Jun 5, 2017

Also the update wants massive new rights to read/modify all web data. As I do not see any commit related to this I uninstalled the app for now. Is there any official statement about this?

@adityabhaskar
Copy link

adityabhaskar commented Jun 5, 2017

I lost all my open tabs too.

The reason is that since there are additional permissions, Chrome disables the extension as a security measure till we enable it manually. And since it disables the extension, it also closes all the tabs of the extension, i.e. all tabs suspended by the extension.
#322 seems to be the actual reason.

The solution, for now, is to allow the permissions, and enable the extension. Then go to this link (chrome-extension://klbibkeccnjlkjkiokjodocebajanakg/history.html) and restore the last saved session from there.

The correct thing to do, for the developers, would have been to add the new permissions as optional in the manifest. Then open the options page on update, and prompt for permission from there. This wouldn't make Chrome disable the extension (thus closing all tabs), and make the transition easier for users.

@mcamou
Copy link
Author

mcamou commented Jun 5, 2017

That did not work, chrome-extension://klbibkeccnjlkjkiokjodocebajanakg/history.html gave me a 404. I have uninstalled the extension, since I really can't afford to have something that will delete my data without notice.

@adityabhaskar
Copy link

@mcamou Do you have the extension enabled?

If so, go to extension's settings/options, then to Session Management, and restore from there.

@faultylee
Copy link

The updated feature is good, but I wished there was a warning before this major changes. The history from the extension contains only tabs, no "windows", so all my suspended tabs goes into 1 window, had to manually sort them out. Imagine this happened in the middle of work, when we needed those tabs as soon as possible.

@deanoemcke
Copy link
Collaborator

Im not sure what is going on. panic stations! i have lost control of the extension from the chrome developer dashboard. v6.22 does not even exist. i had no hand in this getting forced upon users.
i will update here when i know more :(

@ekapujiw2002
Copy link

Oh my God...
Hopefully will get thing done
really love the extention
maybe it is use by someone to steal user info?

@deanoemcke
Copy link
Collaborator

I'm in contact with Google and they're helping me resolve the issue. Fingers crossed I'll have it back soon.
I've checked the code of the new version that has been pushed to the webstore. There is nothing malicious in it, just a version number change. I think the huge storm of activity is due to everybody suddenly being forced to update. It's something I had deliberately avoided doing for exactly this reason. It's a real shame, and the blame ultimately falls on me for allowing my developer account to be compromised.
Huge apologies to everyone affected by this. I'll try to work out the best way to get the message out to the non-github community.

@ekapujiw2002
Copy link

Bravo

@Cris70
Copy link

Cris70 commented Jun 6, 2017

Maybe the new extension does not have malicious code in it, but once the users have accepted the new authorizations requested, and with the account in the hands of an unknown developer, it's just a matter of time when malicious code will start appearing.
Fortunately when I saw the new unjustified authorization requests I turned to github to see if they were genuine. But how many users will do this?
Please spread the word...

@romario300
Copy link

as the author explains finally: what he needs to "change all user data on all websites" ??? This is simply not acceptable !!! Because it gives the author access to passwords and personal data !!! Why so abuse the trust of users ??? And most importantly - this writer does not speak a word !!! WHY?!?

@mcamou
Copy link
Author

mcamou commented Jun 6, 2017

@romario300 see the author's (@deanoemcke) replies above

@romario300
Copy link

Thank you my friend, who answered! ))
But if that happened attackers broke Developer account, I think the author has himself everywhere wherever possible immediately notify all users that they are not updated and expand temporarily disabled until the problem is solved! Is not it?
 Because many users will not delve into the nuances and do not know that you can not in any case allow any expansion modify all user data on sites (eg I did not previously know) !!! So many people do not understand and permit attackers!
 This author also had to inform people as soon as possible! Is not it? Instead, the author sat quietly until many users have begun to ask about it! Is not that surprising?

@gregschwartz
Copy link

Chrome is automatically disabling the extension, which causes all tabs with it to suddenly be closed. Scary and confusing; wish Chrome showed a notification for it. Checking the Extensions window, it shows "This extension contains a serious security vulnerability." under The Great Suspender.

@deanoemcke thank you for watching our backs, I love the extension! Once it gets restored, do you know if it will be possible to recover tabs that were closed? Regardless, I'll keep using it. It's the only way my machine can handle this many tabs being open...

@DAOWAce
Copy link

DAOWAce commented Jun 6, 2017

There is nothing malicious in it, just a version number change.

So I can re-enable and continue using it without issue?

Sitting here watching a video and suddenly 85% of my tabs disappear. I look at the extension, see it disabled with a "this contains a serious vulnerability" message.

Took for granted how much I relied on this extension, just as I did the Firefox ones (700 open tabs over there).

Gotta love Google's walled garden with forced automatic updating of extensions and no way for the user to disable it without directly editing the extension's files. Shame Mozilla went AWOL with Firefox's design and forced me to change.. never liked how Google handles things, never will.

@pedrosimao
Copy link

I just had the same thing. So... the security issue is real? Or we can re-enable the extension without a problem?

@anosci
Copy link

anosci commented Jun 6, 2017

Oh, well this explains what happened to my tabs.

I lucked out a bit though, since I also use Session Buddy. I was able to restore most of my suspended tabs (except for a few that i suspended before last closing my browser...), though each one just gives a 404.

I saw a mention of chrome-extension://klbibkeccnjlkjkiokjodocebajanakg/history.html in an earlier post. Does this mean there's a way to view the history of the tabs you've suspended? That would be handy.

@profpandabear
Copy link

@deanoemcke can you confirm last safe version is 6.22?

@brandondees
Copy link

I just got wiped out by google's disable, which was surprising and confusing, but I suspect erring on the secure side is the right move here. @deanoemcke keep us posted on any resolution / recovery steps?

@chocolatkey
Copy link

@anosci Yes if you go into the extension's settings you can view recent sessions (like yesterday).

@sammarcus
Copy link

Google marking this as having a vulnerability definitely happened within the last 10 minutes. The developer said he was in contact with Google after he found out his account was compromised. I suppose this is Google's solution, for the time being.

It's really weird someone would update this, request additional permissions but only bump the version? Why wouldn't they do more than that if they had negative intent to compromise the account in the first place?

@Corrodias
Copy link

Corrodias commented Jun 6, 2017

The automatic updating actually worked perfectly on my desktop: When the addon updated (to the hacked version), the tabs disappeared, but then a TGS tab opened asking if i wanted to restore the tabs that closed (under the assumption that it had crashed). They went back where they were. It was great.

Now, of course, it has been disabled, and I understand that I shouldn't enable it. Still, just thought I'd share that anecdote.

@liamjohnston
Copy link
Contributor

liamjohnston commented Jun 6, 2017 via email

@d9i
Copy link

d9i commented Jun 6, 2017

@deanoemcke I'm so sorry this happened to you! I was just affected by Chrome mass-disabling the extension too, and I came here for more info.

Also, consider updating the readme.md with a short notice to let people know why their extension was suddenly disabled. That should reduce the amount of confusion everyone's experiencing 😝

Best of luck working with Google to get this figured out!

@sammarcus
Copy link

@shanempope I haven't examined the code from the recent Web Store version, I was only going off of @deanoemcke comment from above.

@liamjohnston I feel confident in saying 98%+ of the people using this extension are using the version from the Chrome Web Store 😄

@ufo56
Copy link

ufo56 commented Jun 6, 2017

I hope it comes back soon. I was like WTF where my tabs are suddenly. :D
Disabled it at moment.
Most useful extension of chrome. Keep up good work!

@MaxWinterstein
Copy link

Came here also as suddenly my tabs disappeared. Had to give a closer look to find the related issue. +1 for README.md update 😉

@sammarcus
Copy link

image

@RJVB
Copy link

RJVB commented Jun 7, 2017 via email

@eoosting
Copy link

eoosting commented Jun 7, 2017

this plagued me as well.

However, after update make sure the extension is enabled, and I was able to restore my session by going to extension's settings/options, then to Session Management, and then selecting a session to restore.

not ideal, but perfectly acceptable workaround.

@RJVB
Copy link

RJVB commented Jun 7, 2017 via email

@netikras
Copy link

netikras commented Jun 7, 2017

Yesterday 72 tabs disappeared from my browser as if they were never there. I already had my cat punished for allegedly catwalk'ing on my keyboard. And here it is - the extension I like the most was actually to blame! Oh well :)

Just now I came home from work and woke up my laptop. And guess what! The extension auto-updated itself and restored all my tabs itself. How cool is that! Hats off to the author @deanoemcke . Really man, thank you :) Nice trick you did there! Very customer-oriented attitude.

@Ihysoal
Copy link

Ihysoal commented Jun 7, 2017

I would like to emphasize that you people with 50+ tabs consistently suspended have an actual problem.

@zoechi
Copy link

zoechi commented Jun 7, 2017

@Ihysoal what kind of problem do you mean?
Lack of support in Chrome for power users?

@mkrier
Copy link

mkrier commented Jun 7, 2017

Want to reiterated the recommendation for Session Buddy, but also- most people don't know this- If you quit chrome form the taskbar (in windows at least) by right clicking on it, then you only get the top window restored. Whereas, if you quit it within chrome itself from the settings menu, you get all of them back. (I mean, as a general thing- not a specific issue with Suspender, I'm just saying as a general thing about chrome.)

I don't know if that's true in Ubuntu because I figured that out back when I was running windows before I made the switch. (And I'm not going to test that here lol)

@sammarcus
Copy link

@Master-1-

someone tried to login and reset my password on one of my accounts. I suspect it was because of this hack.

Chrome extensions are sandboxed to the extent that any damage would have had to come from the code we've inspected. It's been reviewed line by line and there wasn't anything malicious. So it would have had to have been something else.

@pmonks
Copy link

pmonks commented Jun 7, 2017

It appears that this morning's update has fixed this issue - Chrome is no longer reporting a serious security vulnerability with this extension.

👍 Fantastic work @deanoemcke - absolutely spectacular turnaround on this issue! 👍

@kekukui
Copy link

kekukui commented Jun 7, 2017

deanoemcke wrote:

"the blame ultimately falls on me for allowing my developer account to be compromised."

So that others could benefit from the lesson...

Please disclose the method of compromise.

@uecasm
Copy link

uecasm commented Jun 7, 2017

@Master-1-

Thanks for the updates but I have to take into account that there might have been a malicious activity because yesterday around 12:45 someone tried to login and reset my password on one of my accounts. I suspect it was because of this hack. Not 100% sure though. Just letting you know.

Note that this can also happen if one of your suspended tabs happened to be a password reset page, and during the course of things it was reloaded unsuspended at some point. (This shouldn't be the case since password resets should use a nonce so they're invalid if the page is reloaded, but many websites don't do that, so this can indeed happen.)

@adcurtin
Copy link

adcurtin commented Jun 8, 2017

so what happened today? I had 6.30 enabled, but all my tabs disappeared again, and they're not in the session manager this time. Strangely, the extension was still enabled.

Is there a file I can grab from time machine or a full backup I have to get my crap back?

Edit:
the answer is yes. the files that mattered were in the Indexeddb folder.
Here's the full path on OS X: ~/Library/Application Support/Google/Chrome/Default/IndexedDB/chrome-extension_klbibkeccnjlkjkiokjodocebajanakg_0.indexeddb.leveldb

restoring that folder from my backup got me my tabs back.

@deanoemcke
Copy link
Collaborator

@Master-1- The compromised extension did not contain any malicious code (thankfully!). I ran checks over the unsolicited release and there was no actual code changes in there. So there is no chance that this event is related to any hacking attempt you might have seen. I'm still unsure as to exactly what the intentions were of the attackers. Perhaps ownership was restored to me before they had a chance to implement whatever they had planned.

@faultylee Any update will cause loss of tabs, so it's impossible to pre-warn. And I feel like such a message would just cause general confusion anyway. I still believe that the best way to handle this going forward is to simple NEVER UPDATE the extension automatically. As long as the code is relatively bug-free then this is the best course of action for the sanity of the users.

@RJVB
Copy link

RJVB commented Jun 8, 2017 via email

@faultylee
Copy link

faultylee commented Jun 8, 2017

@RJVB thank you, that's what I meant.
@deanoemcke I suspect the reason those tabs are lost is that there's 2 new permission which chrome needs to request user to accept. If a "warning message" is pushed one version before like what @RJVB describe, without those new permission, then it should not have cause the tabs to be lost.

I don't meant to sound ungrateful, I'm actually grateful and happy with the extension thus far. Just looking for way to make the experience even better.

After all, I would actually blame chrome for this short coming, as it has very broad api to allow devs to do almost anything, and imposing certain feature (like autoupdate) without setting any guideline in terms of user experience

@crafty-geek
Copy link

crafty-geek commented Jun 8, 2017 via email

@deanoemcke
Copy link
Collaborator

deanoemcke commented Jun 8, 2017

@RJVB

But isn't there a way around this all? As a user I can tell the extension to unsuspend all tabs, what if you make it do that before updating, so that those tabs are no longer owned by the extension? I don't know if you can detect "I'm going to be updated" events, or even "I'm going to quit" but it seems the extensions API must provide something of the sort to allow extensions to clean up after them when the user disables or removes them.

This is exactly the issue. The API does not provide any ability to detect "Im going to be updated" or "Im going to quit". There is only a "Im going to be uninstalled" which does not help. Therefore, once again I reiterate, the only person who knows when an update is coming is me, based on when I push a new version. Even then, I cannot control when this version will be updated on a clients browser.

I could post a warning, but then how long do I wait before pushing the update? Waiting less than a day, I risk most users not getting a chance to read the warning. Waiting more than a day, I risk users forgetting about it, creating many more tabs, and then getting caught offguard when the update does happen. I'm not saying warning users is a bad idea, just that it is far from an elegant solution to the problem.

My ongoing policy with updates has always been to warn users first. However, my ongoing policy has also been never to push an update, so I've never actually had to exercise this warning.

@deanoemcke
Copy link
Collaborator

@faultylee
The reason tabs are lost has nothing to do with elevated permissions. It is purely a consequence of the extension having to restart to perform any sort of update. As soon as an update is forced by chrome, the extension is forced to close (without warning). This causes all suspended tabs to disappear.

I have integrated some session management code which should detect this situation after the update and automatically restore these lost tabs. However, the code is not fool proof and does not work 100% of the time. And it assumes the extension remains enabled - which was not the case for a period of time during the incident recently.

@deanoemcke
Copy link
Collaborator

@crafty-geek This has been suggested before. The idea of the Great Suspender beta which is subject to updates at the users risk.

There's nothing stopping me doing it. I don't really like the added confusion that would create on the webstore, but I might consider it if there is enough demand. You can always install the latest code from the gitHub project page so that is essentially the work-around.

@deanoemcke
Copy link
Collaborator

@h3298 I am currently working on a post mortem of the hack and will post it as a medium article shortly.

@deanoemcke
Copy link
Collaborator

deanoemcke commented Jun 8, 2017

Closing this issue as it doesn't reflect the issue title and is a bit messy. Consider this the official thread for 'fallout from the extension being compromised'

For issues related to lost tabs caused by the extension updating, please refer to this issue: #526

@x1ddos
Copy link

x1ddos commented Jun 8, 2017

@deanoemcke could you please post here the postmortem URL whenever it's ready. I don't know how to find you on medium.

@deanoemcke
Copy link
Collaborator

@x1ddos that's because i'm not on medium (yet) :)
Will post here once it's done, although I haven't started yet. I wanted to get the guide for recovering lost tabs done first (#526)

@RJVB
Copy link

RJVB commented Jun 8, 2017 via email

@sammarcus
Copy link

@deanoemcke was curious if you ever did a write up about this now that it's all over. would be interested in hearing your insights and experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests