GUI status log comments #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I reverted that PR separately. Could you rebase the PR on latest master? I'd merge it then. Thanks! |
simons-public
force-pushed
the
gui-status-log-comments
branch
from
b7d5161
to
7331519
Compare
|
@p12tic no problem, it's rebased on master now |
p12tic
approved these changes
Jun 6, 2020
|
Thanks! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds comments explaining the reason for using CLOG_PRINT for certain status messages. It also reverts #725 which reintroduces issues #652 and #516.
@p12tic This also covers #738 if you want to close that, sorry I didn't include these comments in the first place.