DBZ-2619 Adding few social share buttons #620
Conversation
|
So I like the idea of share buttons, but can we make them more privacy-friendly? I.e. instead of directly calling those remote URLs, put this behind one more click, so the user consciously opts into this. E.g. see here for one possible solution: https://www.heise.de/extras/socialshareprivacy/ (it's in German, but you'll find similar things described in English, too). |
|
@gunnarmorling Updated the PR. |
|
Hey @uidoyen, nice work overall! A few remarks:
|
| @@ -0,0 +1,154 @@ | |||
| "use strict"; | |||
|
|
|||
| (function ($,undefined) { | |||
There was a problem hiding this comment.
Why do we need this cookie logic?
There was a problem hiding this comment.
Cookie logic is to enable share buttons permanently.
|
Can we do without that permanent feature? We'd need cookie policy
disclaimer and option to opt-out for European countries, and it's all not
worth the hassle.
… |
Removed permanent feature. |
As per panzi/SocialSharePrivacy#50 Facebook is only a link and no request to Facebook is made to display it. Fixed the rest. |
|
Hey @uidoyen, could you rebase this and push it to the preview environment if you got some cycles? @hguerrero was just asking for this feature :) |
|
@gunnarmorling Done! |
|
Thx! Did you push it to staging, I can't seem to find it there.
… |
@gunnarmorling Just pushed it to |
|
@gunnarmorling @hguerrero Could you please review the staging? |
|
Hi @uidoyen I'm sorry this has fallen through the cracks. If this is still relevant, could you rebase this PR for me? I'll then take a look and review the changes, thanks! |
No description provided.