Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Edit on GitHub' links 404 #91

Closed
davisonio opened this issue Oct 16, 2015 · 2 comments
Closed

'Edit on GitHub' links 404 #91

davisonio opened this issue Oct 16, 2015 · 2 comments
Assignees
@ypid
Labels
bug help wanted reported upstream

Comments

@davisonio
Copy link

When using the button on any page which is included into the docs via a submodule produces a 404 error.
@drybjed
Copy link
Member

drybjed commented Oct 16, 2015

DebOps uses ReadTheDocs template by default. Is there a way to change the "Edit on GitHub" link via some template string?

@ypid ypid mentioned this issue Nov 1, 2015
Closed
@ypid ypid mentioned this issue Jul 1, 2016
Open
ypid added a commit to ypid/docs-1 that referenced this issue Aug 14, 2016
@ypid
Enable local Readthedocs theme and disable "Edit on GitHub"
940524f 
Ref: https://stackoverflow.com/questions/36019670/removing-the-edit-on-github-link-when-using-read-the-docs-sphinx-with-readthed
Related to: debops#91

If removal is successful, test: http://mg.pov.lt/blog/sphinx-edit-on-github.html
@ypid ypid mentioned this issue Aug 14, 2016
Merged
ypid added a commit to ypid/docs-1 that referenced this issue Aug 14, 2016
@ypid
Enable local Readthedocs theme and disable "Edit on GitHub"
eb43ae2 
Ref: https://stackoverflow.com/questions/36019670/removing-the-edit-on-github-link-when-using-read-the-docs-sphinx-with-readthed
Related to: debops#91

If removal is successful, test: http://mg.pov.lt/blog/sphinx-edit-on-github.html
@ypid ypid self-assigned this Aug 14, 2016
ypid added a commit to ypid/docs-1 that referenced this issue Aug 14, 2016
@ypid
Enable local Readthedocs theme and disable "Edit on GitHub"
97f5bcd 
Ref: https://stackoverflow.com/questions/36019670/removing-the-edit-on-github-link-when-using-read-the-docs-sphinx-with-readthed
Related to: debops#91

If removal is successful, test: http://mg.pov.lt/blog/sphinx-edit-on-github.html
ypid added a commit to ypid/docs-1 that referenced this issue Aug 14, 2016
@ypid
Fix "Edit on GitHub" links for git submodules to make users happy
52ee6f6 
Fixes: debops#91
@ypid ypid mentioned this issue Aug 14, 2016
Merged
ypid added a commit to ypid/docs-1 that referenced this issue Aug 14, 2016
@ypid
Fix "Edit on GitHub" links for git submodules to make users happy
3481084 
Fixes: debops#91
ypid added a commit to ypid/docs-1 that referenced this issue Aug 14, 2016
@ypid
Fix "Edit on GitHub" links for git submodules to make users happy
48a9070 
Fixes: debops#91
@ypid ypid closed this as completed in #210 Aug 14, 2016
@ypid
Copy link
Member

ypid commented Aug 14, 2016

@drybjed Noted that the button on the left which needs to be expanded first still redirects to the wrong target. Currently, only the big "Edit on GitHub" at the top right of the page works. It is left to the reader to figure out how to fix the bottom one 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ypid ypid

Labels
bug help wanted reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drybjed @ypid @davisonio