fix: avoid unnecessary rerenders (#7004)

* fix: avoid unnecessary rerenders while assets are loading * fix: formatting --------- Co-authored-by: spereirag <sapereirag@gmai.com> Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
decaporg · Dec 19, 2023 · fdfb497 · fdfb497
1 parent 2ec8406
commit fdfb497
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js b/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js
@@ -204,6 +204,7 @@ class EditorControl extends React.Component {
       parentIds,
       t,
       validateMetaField,
+      isLoadingAsset,
       isDisabled,
       isHidden,
       isFieldDuplicate,
@@ -329,6 +330,7 @@ class EditorControl extends React.Component {
               isDisabled={isDisabled}
               isFieldDuplicate={isFieldDuplicate}
               isFieldHidden={isFieldHidden}
+              isLoadingAsset={isLoadingAsset}
               locale={locale}
             />
             {fieldHint && (

diff --git a/packages/decap-cms-core/src/components/Editor/EditorControlPane/Widget.js b/packages/decap-cms-core/src/components/Editor/EditorControlPane/Widget.js
@@ -75,6 +75,10 @@ export default class Widget extends Component {
   };
 
   shouldComponentUpdate(nextProps) {
+    /**
+     * Avoid unnecessary rerenders while loading assets.
+     */
+    if (this.props.isLoadingAsset) return false;
     /**
      * Allow widgets to provide their own `shouldComponentUpdate` method.
      */