-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-fast-forward error on quick image edit #308
Comments
This same problem happens regardless of whether it's an image or not. Just modifying a text field triggers the issue. Waiting a short period of time works around the issue. |
It is quite a big issue.
|
This should solve issues like #308 and the issues with cached API responses after deleting an entry
This should solve issues like #308 and the issues with cached API responses after deleting an entry
@Benaiah can you retest this now that the cache buster is merged? |
I have not tested thoroughly, but I have not seen in pop up and non one has reported it to me in a bit. I'll try to recreated problem case tonight. |
This bug is due to getting a stale SHA of a git branch from GitHub, and then trying to push a commit that has an incorrect parent. This bug hasn't been reported since we merged the cachebuster, except in git-gateway because it doesn't currently have a cachebuster. |
The last instance of this has been closed in #672. |
- Do you want to request a feature or report a bug?
- What is the current behavior?
- If the current behavior is a bug, please provide the steps to reproduce.
above ^^
- What is the expected behavior?
The expected behavior is either a more descriptive error for non technical people, or first fetching and merging as described here: https://help.github.com/articles/dealing-with-non-fast-forward-errors/
- Please mention your node.js, and operating system version.
Node v7.7.1, Mac OS Sierra 10.12.3
The text was updated successfully, but these errors were encountered: