Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-fast-forward error on quick image edit #308

Closed
puppycodes opened this issue Mar 19, 2017 · 7 comments
Closed

non-fast-forward error on quick image edit #308

puppycodes opened this issue Mar 19, 2017 · 7 comments
Assignees
Milestone

Comments

@puppycodes
Copy link

- Do you want to request a feature or report a bug?

  • Bug

- What is the current behavior?

  • Currently in the Kaldi CMS example, when a post is created and an image is uploaded to the image field, then saved, and then immediately edited and a new image uploaded to replace the original image an error is produced "Failed to persist entry: API_ERROR: Update is not a fast forward" and the image cannot be updated.

screenshot 2017-03-19 13 39 01

- If the current behavior is a bug, please provide the steps to reproduce.
above ^^

- What is the expected behavior?
The expected behavior is either a more descriptive error for non technical people, or first fetching and merging as described here: https://help.github.com/articles/dealing-with-non-fast-forward-errors/

- Please mention your node.js, and operating system version.

Node v7.7.1, Mac OS Sierra 10.12.3

@fraktar
Copy link

fraktar commented Mar 20, 2017

+1 got the same error.

netlify-cms-error

@jholmes033169
Copy link
Contributor

This same problem happens regardless of whether it's an image or not. Just modifying a text field triggers the issue. Waiting a short period of time works around the issue.

@abumalick
Copy link
Contributor

It is quite a big issue.
Did you find any quick fix for this ?
It is hard to tell my client:

Wait 2 minutes between edits.

biilmann added a commit that referenced this issue Jun 10, 2017
This should solve issues like #308 and the issues with cached
API responses after deleting an entry
Benaiah pushed a commit that referenced this issue Jun 12, 2017
This should solve issues like #308 and the issues with cached
API responses after deleting an entry
@erquhart
Copy link
Contributor

@Benaiah can you retest this now that the cache buster is merged?

@jholmes033169
Copy link
Contributor

I have not tested thoroughly, but I have not seen in pop up and non one has reported it to me in a bit. I'll try to recreated problem case tonight.

@Benaiah
Copy link
Contributor

Benaiah commented Oct 9, 2017

This bug is due to getting a stale SHA of a git branch from GitHub, and then trying to push a commit that has an incorrect parent. This bug hasn't been reported since we merged the cachebuster, except in git-gateway because it doesn't currently have a cachebuster.

@Benaiah
Copy link
Contributor

Benaiah commented Oct 10, 2017

The last instance of this has been closed in #672.

@Benaiah Benaiah closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants