-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use drag handles for list control drag/drop #431
Use drag handles for list control drag/drop #431
Comments
Is this at a |
Hey @andreasvirkus, that'd be awesome! I don't imagine it'd be too difficult - it should be supported by the drag/drop library we're using, but I haven't looked into it. Definitely take a crack at it, you can post questions in Gitter if you run into issues. |
I hit a small road block with the react-sortable lib we use. It's easy to disable dragging for all children of the draggable, fixing the initial bug described. But I've found no way to re-enable it for a specific child element afterwards. I also asked for help under the lib's issues, but haven't received any feedback yet. I reached out to Daniel (owner) on his e-mail, but if that doesn't amount to anything, would it be ok for me to try out a different lib react-draggable? They've got the drag handles in their example as well so it's definitely a feature they support. |
@andreasvirkus I'm not against using a different lib - for our purposes, this one seems the most promising: https://github.com/clauderic/react-sortable-hoc |
@erquhart Good find, will dive into it tonight! |
@andreasvirkus just a heads up, @Benaiah seems to have included this in some recent work that required this fix: #468. If you're up for reviewing, it'd be a great help! I can also point you toward another issue if you don't already have one mind - just reach out on Gitter :) |
- Do you want to request a feature or report a bug?
bug
- What is the current behavior?
Each object in a list control can be dragged from any point. When attempting to select text inside of a list control, you'll often drag the entire object of controls instead.
- If the current behavior is a bug, please provide the steps to reproduce.
- What is the expected behavior?
- Requirements
The text was updated successfully, but these errors were encountered: