Migrate ListControl from react-sortable to react-sortable-hoc #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erquhart sounds good, will do! |
Benaiah
force-pushed
the
react-sortable-hoc-upgrade
branch
from
a6f5f0e
to
3b8b218
Compare
|
Found a style regression, probably due to rebasing over the CSS migration:
Whole bar should appear gray and seamless. |
|
Never mind, looks like that's on master. Fixing. |
erquhart
force-pushed
the
react-sortable-hoc-upgrade
branch
from
3b8b218
to
79ce94a
Compare
|
@erquhart thanks for pushing that fix! That commit looks good to me. |
erquhart
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Migrates ListControl from
react-sortabletoreact-sortable-hocand enables drag handles. Closes #431.(this may be closed in favor of a PR using https://github.com/atlassian/react-beautiful-dnd)
- Test plan
Manually tested, including nested lists.
- Description for the changelog
Migrate ListControl from react-sortable to react-sortable-hoc
- A picture of a cute animal (not mandatory but encouraged)