feat: add choose url option to file or image ts interface #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello? Is anyone here? :) |
|
Why is no one picking this up? Getting feedback on what/if anything is missing would be highly appreciated. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
martinjagodic
approved these changes
Apr 28, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
Co-authored-by: Marco Pagni <stiwwelll@users.noreply.github.com>
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: Marco Pagni <stiwwelll@users.noreply.github.com>
|
Now I've taken my time....thanks a lot @martinjagodic 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When implementing the option to add a
choose_urlflag to the image widget #5572 the TS interface declaration forCmsFieldFileOrImagehas not been adapted accordingly which keeps the user to set this option when declaring a field with TypescriptTest plan
na/
Checklist
Please add a
xinside each checkbox:yarn format.yarn test.