Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: image widget insert from url should be optional #5572

Merged
merged 4 commits into from
Jul 5, 2021
Merged

feat: image widget insert from url should be optional #5572

merged 4 commits into from
Jul 5, 2021

Conversation

Edald123
Copy link
Contributor

@Edald123 Edald123 commented Jul 2, 2021

Summary
Fixes: Image widget "Insert From URL" should be optional as requested here: #5558

Test plan
By puting the option choose_url as true:
image

We see this in the cover image section when creating a new post:
image

By putting false:
image

We see that the option of Insert From URL does not appear:
image

A picture of a cute animal (not mandatory but encouraged)
Screenshot_2021-07-01-21-01-52-48_2

@Edald123 Edald123 requested a review from a team July 2, 2021 02:18
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 5, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @Edald123. I made some minor changes to the docs and to return null instead of an empty string

@erezrokah erezrokah merged commit 18724ff into decaporg:master Jul 5, 2021
@madsem
Copy link

madsem commented Jul 5, 2021

Huzzah, thanks @Edald123 & @erezrokah

@Edald123
Copy link
Contributor Author

Edald123 commented Jul 5, 2021

Great, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants