Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1457, int val output in TOML format, adds test #1458

Merged
merged 6 commits into from
Jun 26, 2018
Merged

Fixes #1457, int val output in TOML format, adds test #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
73f8bfc
Fix int val output in TOML format, add test
slathrop Jun 20, 2018
0a9be7b
Preferred str conversion, separate test spec
slathrop Jun 21, 2018
479940e
Cleanup original frontmatter test spec
slathrop Jun 21, 2018
6375dfe
Revert to prev frontmatter spec
slathrop Jun 21, 2018
747788f
rm IE polyfill as CMS doesn't support IE
slathrop Jun 21, 2018
7b877e0
Clarify tomlify output replacer w comment
slathrop Jun 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/formats/__tests__/tomlFormatter.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import tomlFormatter from '../toml';

describe('tomlFormatter', () => {
it('should output TOML integer values without decimals', () => {
expect(
tomlFormatter.toFile({ testFloat: 123.456, testInteger: 789, title: 'TOML' })
).toEqual(
[
'testFloat = 123.456',
'testInteger = 789',
'title = "TOML"'
].join('\n')
);
});
});
4 changes: 4 additions & 0 deletions src/formats/toml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const outputReplacer = (key, value) => {
if (value instanceof AssetProxy) {
return `${ value.path }`;
}
if (Number.isInteger(value)) {
// Return the string representation of integers so tomlify won't render with tenths (".0")
return value.toString();
}
// Return `false` to use default (`undefined` would delete key).
return false;
};
Expand Down