Update configSchema.js to allow arrays for frontmatter_delimiter #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims to resolve #1996 in which array values for `frontmatter_delimiter` throw an error `'frontmatter_delimiter' should be string`
|
Preview proposed changes to netlifycms.org in the link below: Built with commit 0aa3ac4 |
|
Preview proposed changes to the CMS demo site in the link below: Built with commit 0aa3ac4 |
Benaiah
reviewed
Jan 17, 2019
| @@ -96,7 +96,7 @@ const getConfigSchema = () => ({ | |||
| }, | |||
| format: { type: 'string', enum: Object.keys(formatExtensions) }, | |||
| extension: { type: 'string' }, | |||
| frontmatter_delimiter: { type: 'string' }, | |||
| frontmatter_delimiter: { type: ['string', 'array'] }, | |||
There was a problem hiding this comment.
This schema will allow an array of any type, rather than only an array of strings. It should be modified to specify that the children of arrays should be strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to resolve #1996 in which array values for
frontmatter_delimiterthrow an error'frontmatter_delimiter' should be stringSummary
See #1996 for details. The schema validator appears not to have been updated in PRs #1064 & #1094 to allow for arrays per the documentation.
Test plan
Following development steps on CONTRIBUTING.md