Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#359 - Handle metadata for all children of a list field #360

Merged

Conversation

lmcorreia
Copy link
Contributor

- Summary

- Test plan

  • I know, no excuses for not writing any tests but I ended up having to test it all manually anyway in my use case. Adding, removing and updating any child of the list works, there are no incompatibilities with the current version, nothing needs to be changed in the docs (they don't go very deep into the relation widget anyway - room for improvement in another contribution), now works as expected. If you did the setup to confirm the bug exists (see Only partial relation metadata available on list previews #359), just adding, editing and removing entries in the list field should be enough to confirm that the metadata now comes as expected.

- Description for the changelog

  • Handle metadata for all children of a list field

- A picture of a cute animal (not mandatory but encouraged)
wiki

@lmcorreia lmcorreia changed the title #359 - Handle metadata for all children of a list field [DO NOT MERGE] #359 - Handle metadata for all children of a list field Apr 13, 2017
@lmcorreia
Copy link
Contributor Author

Sorry, just noticed a little screw up in the diff from screwing around with values, fixing it

@lmcorreia lmcorreia changed the title [DO NOT MERGE] #359 - Handle metadata for all children of a list field #359 - Handle metadata for all children of a list field Apr 13, 2017
@lmcorreia
Copy link
Contributor Author

^ Now we're good :)

Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the webpack footer.



// WEBPACK FOOTER //
// ./components/Widgets/ListControl.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these lines were left in inadvertently.

@josephearl
Copy link
Contributor

@Benaiah @lmcorreia webpack footer removed

@josephearl josephearl dismissed Benaiah’s stale review April 14, 2017 15:56

Webpack footer has been removed

@josephearl
Copy link
Contributor

LGTM

@erquhart erquhart merged commit 2047fda into decaporg:master Apr 14, 2017
@lmcorreia
Copy link
Contributor Author

Sorry, must have been my build settings. Thanks for the commit, @josephearl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants