-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#359 - Handle metadata for all children of a list field #360
#359 - Handle metadata for all children of a list field #360
Conversation
Sorry, just noticed a little screw up in the diff from screwing around with values, fixing it |
^ Now we're good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove the webpack footer.
|
||
|
||
// WEBPACK FOOTER // | ||
// ./components/Widgets/ListControl.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these lines were left in inadvertently.
@Benaiah @lmcorreia webpack footer removed |
LGTM |
Sorry, must have been my build settings. Thanks for the commit, @josephearl |
- Summary
- Test plan
list
works, there are no incompatibilities with the current version, nothing needs to be changed in the docs (they don't go very deep into therelation
widget anyway - room for improvement in another contribution), now works as expected. If you did the setup to confirm the bug exists (see Only partial relation metadata available on list previews #359), just adding, editing and removing entries in the list field should be enough to confirm that the metadata now comes as expected.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)