Use react-frame-component for preview pane #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benaiah
force-pushed
the
react-frame-component
branch
2 times, most recently
from
6334a5f
to
031187f
Compare
Benaiah
changed the title
erquhart
suggested changes
May 5, 2017
| </ScrollSyncPane> | ||
| , this.previewEl); | ||
| } | ||
| const styleEl = <link href={registry.getPreviewStyles()} type="text/css" rel="stylesheet" />; |
There was a problem hiding this comment.
registry.getPreviewStyles returns an array - we should be mapping it.
| ref.contentDocument.head.appendChild(linkEl); | ||
| }); | ||
|
|
||
| const base = document.createElement('base'); |
There was a problem hiding this comment.
I believe we'll need this to avoid regression of #172.
There was a problem hiding this comment.
Resolved this by adding it to the initialContent prop on Frame.
|
@Benaiah update still coming for this? |
Benaiah
force-pushed
the
react-frame-component
branch
from
031187f
to
5090060
Compare
erquhart
suggested changes
May 8, 2017
| }; | ||
|
|
||
| return (<Frame | ||
| className={styles.frame}more** crazy stuff |
There was a problem hiding this comment.
ugh, middle-click paste is not my friend sometimes 😛
This fixes the preview pane not working in Firefox
Benaiah
force-pushed
the
react-frame-component
branch
from
5090060
to
376fed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
- Summary
Uses
react-frame-componentfor preview pane instead of custom iframe code. Fixes #307.- Test plan
Existing tests pass; manually tested that previewing and scrolling work correctly in both Firefox and Chrome.
- Description for the changelog
Use react-frame-component for preview pane