#415: Images do not show up in cards where space in filename #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholmes033169
changed the title
erquhart
approved these changes
May 11, 2017
|
What is the general timing on a merge? Not pushing... just have clients griping at me about the photos not showing. Would love to tell them something. |
Benaiah
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #415
- Summary
In the current behavior, cards will not show images that have a space in the filename. The solution was to encode spaces to %20 in the normalizePath() method. A more general path encoding should probably be put in place.
- Test plan
- Description for the changelog
normalizePath() now encodes white space to %20
- A picture of a cute animal (not mandatory but encouraged)