fix rte scroll handler firing on child scroll #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benaiah
suggested changes
May 23, 2017
| @@ -9,7 +9,6 @@ | |||
| "test:watch": "jest --watch", | |||
| "build": "NODE_ENV=production webpack --config webpack.prod.js", | |||
| "build:scripts": "NODE_ENV=production webpack --config webpack.cli.js", | |||
| "prepublish": "in-publish && npm run build || not-in-publish", | |||
There was a problem hiding this comment.
These changes don't look related to this PR.
There was a problem hiding this comment.
I actually did add this on purpose, I'll update the PR subject so that's clear.
| @@ -68,7 +67,6 @@ | |||
| "file-loader": "^0.8.5", | |||
| "identity-obj-proxy": "^3.0.0", | |||
| "imports-loader": "^0.6.5", | |||
| "in-publish": "^2.0.0", | |||
There was a problem hiding this comment.
These changes don't look related to this PR.
| @@ -1,5 +1,7 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
These changes don't look related to this PR.
| @@ -81,7 +81,9 @@ export class StickyContext extends Component { | |||
| } | |||
|
|
|||
| handleScroll = (event) => { | |||
| this.updateStickies(event.target); | |||
| if (event.target === this.ref) { | |||
|
@Benaiah have another look, I removed prepublish on purpose. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Code blocks can scroll horizontally in the rich text editor, but those scrolls were
propagating and triggering the scroll handler for the StickyContext component,
causing the toolbar to stick to the top of the scroll context.
This fix ensures that only context scrolls trigger the handler.
Also, fixed an issue where the recently added in-publish script fails CI.