-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relation preview improvements #470
Conversation
Param | Type | Description | ||
--- | --- | --- | ||
`name` | string | Widget name, allows this widget to be used via the field `widget` property in config | ||
`control` | React.Component \| string | <ul><li>React component that renders the control, receives the following props: <ul><li>**value:** Current field value</li><li>**onChange**: Callback function to update the field value</li></ul></li><li>Name of a registered widget whose control should be used (includes built in widgets).</li></ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all of this nested list markup is horrible. I am very ashamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better than nothing! And it does render fairly well. Tables are the worst thing about markdown. 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
746930b
to
9fdc458
Compare
9fdc458
to
6af9a31
Compare
- Summary
This PR addresses three problems:
- Description for the changelog
Allow custom widgets to reuse existing widget controls
- A picture of a cute animal (not mandatory but encouraged)