Reverse change in #415; Image paths encoded before displaying instead #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jholmes033169 mind squashing this to one commit? I'd do it, but rather not force push to your master branch. |
|
There ya go... hope I did that right. Never squashed before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
PR #415 fixed the image path problem, but too deep. The fix created a problem where all images with a space in the image name ended up with "%20" in the actual persisted image name. This was because resolvePath() was obviously used in both display and persist cases (unknown to the author of the fix (me) at the time).
Instead, the image name is now encoded in EntryListing.js right before displaying.
- Test plan
Images display in cards. Uploaded images should no longer have "%20" in their names.
Posts and page types display normally.
- Description for the changelog
Image name is now encoded in EntryListing.js rather than pathHelper.js.
- A picture of a cute animal (not mandatory but encouraged)