Fix denied login for users with many repos. #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
changed the title
erquhart
suggested changes
Aug 19, 2017
src/backends/github/API.js
Outdated
| return contributor; | ||
| }).catch((error) => { | ||
| console.error("Problem with response of /user/repos from GitHub"); | ||
| return this.request(this.repoURL).then((repo) => (repo.permissions.push)).catch((error) => { |
There was a problem hiding this comment.
Nitpick - the extra parens can be dropped, and use multiple lines for clarity:
this.request(...)
.then(repo => repo.permissions.push)
.catch(error => {
...
});There was a problem hiding this comment.
@erquhart this should be done.
`isCollaborator` was created in #491 to block login if a user did not have write (push) permissions to a repo, by going through the list of a users repos until it found the right one. It did not institute pagination, however, so if a user had enough repos that the one in question was on another page, the CMS would assume that they did not have permission and block the login. This commit fixes the problem by calling the API for the specific repo instead of getting the whole list.
tech4him1
force-pushed
the
isCollaborator-fix
branch
from
eed4f92 to
6df35a2
Compare
tech4him1
changed the title
jasonlally
added a commit
to jasonlally/kaldi-hugo-cms-template
that referenced
this pull request
Aug 20, 2017
tech4him1
commented
Aug 20, 2017
| @@ -32,7 +32,7 @@ export default class GitHub { | |||
| this.token = state.token; | |||
| this.api = new API({ token: this.token, branch: this.branch, repo: this.repo, api_root: this.api_root }); | |||
| return this.api.user().then(user => | |||
| this.api.isCollaborator(user.login).then((isCollab) => { | |||
| this.api.hasWriteAccess().then((isCollab) => { | |||
There was a problem hiding this comment.
Should isCollab be changed as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
isCollaboratorwas created in #491 to block login if a user did not have write (push) permissions to a repo, by going through the list of a users repos until it found the right one. It did not institute pagination, however, so if a user had enough repos that the one in question was on another page, the CMS would assume that they did not have permission and block the login. Since there are only about 30 repos per page, this is a fairly significant bug.This commit fixes the problem by calling the API for the specific repo instead of getting the whole list.
- Test plan
Tested manually before and after:
Tested errors after:
- Description for the changelog
Fix denied login for users with many repos.