Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(node.js): build and test with even versions of Node.js #6494

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

bytrangle
Copy link
Collaborator

@bytrangle bytrangle commented Jun 16, 2022

Summary

I've noticed that even PRs that just involve documentation changes have failed recently due to new Node.js version.

I'm changing the Node.js workflow to only build and test on even versions, which enjoy LTS.

Some modules require Node.js no older than certain number. Please tell me if there's a more robust way to declare Node.js versions.

Test plan

I'm not really sure how to test it on my part. Appreciate any pointer.

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

@bytrangle bytrangle added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jun 16, 2022
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@martinjagodic
Copy link
Member

Thanks for the concern @bytrangle, we decided to go with the hardcode way.

@martinjagodic
Copy link
Member

Actually, this makes sense

@martinjagodic martinjagodic reopened this Aug 25, 2023
@martinjagodic martinjagodic merged commit 0aac310 into decaporg:master Aug 25, 2023
martinjagodic pushed a commit that referenced this pull request Oct 16, 2023
* ci(node.js): build and test with even versions of Node.js

* ci(node.js): remove 10.x version
martinjagodic pushed a commit that referenced this pull request Oct 17, 2023
* ci(node.js): build and test with even versions of Node.js

* ci(node.js): remove 10.x version
martinjagodic pushed a commit to geotrev/netlify-cms that referenced this pull request Oct 17, 2023
)

* ci(node.js): build and test with even versions of Node.js

* ci(node.js): remove 10.x version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dev experience kind: enhancement kind: experimental pinned type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants