-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(node.js): build and test with even versions of Node.js #6494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytrangle
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Jun 16, 2022
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Thanks for the concern @bytrangle, we decided to go with the hardcode way. |
Actually, this makes sense |
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
* ci(node.js): build and test with even versions of Node.js * ci(node.js): remove 10.x version
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
* ci(node.js): build and test with even versions of Node.js * ci(node.js): remove 10.x version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dev experience
kind: enhancement
kind: experimental
pinned
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've noticed that even PRs that just involve documentation changes have failed recently due to new Node.js version.
I'm changing the Node.js workflow to only build and test on even versions, which enjoy LTS.
Some modules require Node.js no older than certain number. Please tell me if there's a more robust way to declare Node.js versions.
Test plan
I'm not really sure how to test it on my part. Appreciate any pointer.
Checklist
Please add a x inside each checkbox: