Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emotion to v11 #6645

Closed

Conversation

vbrzezina
Copy link

@vbrzezina vbrzezina commented Jan 7, 2023

Summary

Update emotion to v11 for compatibility with MUI5

Test plan

One test site is currently broken and I'm having trouble figuring out why any help appricited

Checklist

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

@vbrzezina vbrzezina requested a review from a team January 7, 2023 16:34
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@martinjagodic
Copy link
Member

martinjagodic commented Aug 24, 2023

@vbrzezina can you please solve the conflicts? They appeared because packages and folders were renamed. We would be happy to merge this!

@martinjagodic
Copy link
Member

@vbrzezina could you solve this? Otherwise, we will pick this up in a new PR.

@demshy
Copy link
Member

demshy commented Sep 8, 2023

Hope you don't mind me updating this, our goal is to get to react 18 and emotion is one of the libraries on top of the priority list before that happens.

@demshy demshy force-pushed the chore/update_emotion_to_v11 branch from 53bc5c6 to 18e998b Compare September 8, 2023 10:25
@demshy
Copy link
Member

demshy commented Oct 12, 2023

closing in favour of #6940 (where we did this a bit cleaner)

@demshy demshy closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants