chore(deps): replace react-sortable-hoc with dnd-kit #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
demshy
changed the title
martinjagodic
approved these changes
Sep 6, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
* chore: replace react-sortable-hoc with dnd-kit in file control * chore: update yarn.lock * fix: allow multiple images with same path * style: cleanup console logs * chore: replace sortable hoc on list control * test: update snapshots * chore: replace dnd implementation in relation control * chore: add dnd-kit deps to appropriate packages * chore: harmonize sensors and clean up * fix: remove sortable for single relation controls * test: add restaurants entity for dnd implementations on one screen * fix: fix file control when value is not an array or list * refactor: merge listitem with parent, update snapshots * test: update selector in field validation test
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
* chore: replace react-sortable-hoc with dnd-kit in file control * chore: update yarn.lock * fix: allow multiple images with same path * style: cleanup console logs * chore: replace sortable hoc on list control * test: update snapshots * chore: replace dnd implementation in relation control * chore: add dnd-kit deps to appropriate packages * chore: harmonize sensors and clean up * fix: remove sortable for single relation controls * test: add restaurants entity for dnd implementations on one screen * fix: fix file control when value is not an array or list * refactor: merge listitem with parent, update snapshots * test: update selector in field validation test
martinjagodic
pushed a commit
to geotrev/netlify-cms
that referenced
this pull request
Oct 17, 2023
* chore: replace react-sortable-hoc with dnd-kit in file control * chore: update yarn.lock * fix: allow multiple images with same path * style: cleanup console logs * chore: replace sortable hoc on list control * test: update snapshots * chore: replace dnd implementation in relation control * chore: add dnd-kit deps to appropriate packages * chore: harmonize sensors and clean up * fix: remove sortable for single relation controls * test: add restaurants entity for dnd implementations on one screen * fix: fix file control when value is not an array or list * refactor: merge listitem with parent, update snapshots * test: update selector in field validation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace react-sortable-hoc with a newer and maintained library for sorting in file control (image gallery), ListControl and RelationControl (where it is coupled with react-select). This is a necessary step before upgrading to react 18.
Test plan
Restaurants entity has been added to the config so this can be tested on one screen. Don't forget to yarn install before testing
Screen.Recording.2023-09-06.at.10.18.46.mov
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)