Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove attempt to get a more comprehensive error #7270

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix: remove attempt to get a more comprehensive error #7270

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
926203f
fix: remove attempt to get a more comprehensive error
martinjagodic Aug 27, 2024
d48e275
Merge branch 'main' into handle-duplicate-field
martinjagodic Aug 30, 2024
6110971
Merge branch 'main' into handle-duplicate-field
martinjagodic Aug 30, 2024
8229ed7
feat(): toast warnings for duplicate keys when loading entrties - wi…
demshy Sep 4, 2024
8911cad
feat: try/catch formattedEntries
martinjagodic Sep 4, 2024
547f5d7
fix: revert config
martinjagodic Sep 4, 2024
8c1b789
refactor: cleanup
martinjagodic Sep 4, 2024
344417b
refactor: cleanup
martinjagodic Sep 4, 2024
7c9b170
refactor: format
martinjagodic Sep 4, 2024
e3c9782
feat: improve error messaging
martinjagodic Sep 4, 2024
caa41f1
fix: pass unit tests
martinjagodic Sep 4, 2024
6a0fca7
refactor: format
martinjagodic Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/decap-cms-core/src/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { attempt, flatten, isError, uniq, trim, sortBy, get, set } from 'lodash';
import { flatten, isError, uniq, trim, sortBy, get, set } from 'lodash';
import { List, fromJS, Set } from 'immutable';
import * as fuzzy from 'fuzzy';
import {
Expand Down Expand Up @@ -869,7 +869,7 @@ export class Backend {
return (entry: EntryValue): EntryValue => {
const format = resolveFormat(collection, entry);
if (entry && entry.raw !== undefined) {
const data = (format && attempt(format.fromFile.bind(format, entry.raw))) || {};
const data = (format && format.fromFile.bind(format, entry.raw)()) || {};
if (isError(data)) console.error(data);
return Object.assign(entry, { data: isError(data) ? {} : data });
}
Expand Down
Loading