Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LW Header Improvements #3195

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

LautaroPetaccio
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio commented Sep 30, 2024

This PR does two things:

  • Improves the LW Header with a new ThirdPartyImage that uses the CollectionImage and the collection type.
  • Changes some tests and mocks in order to avoid loading the sagas or the store when running tests.

Screenshot 2024-09-30 at 14 31 04

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 6:43pm

Copy link

Pull Request Test Coverage Report for Build 11111949827

Details

  • 12 of 14 (85.71%) changed or added relevant lines in 7 files are covered.
  • 38 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.1%) to 48.754%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/common/store.ts 0 1 0.0%
src/modules/poolGroup/sagas.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/modules/tile/reducer.ts 1 71.43%
src/modules/tile/sagas.ts 1 71.43%
src/modules/poolGroup/reducer.ts 1 66.67%
src/lib/api/builder.ts 1 17.06%
src/lib/address.ts 1 76.47%
src/modules/modal/sagas.ts 2 62.5%
src/modules/poolGroup/sagas.ts 2 43.75%
src/lib/api/auth.ts 4 21.21%
src/modules/collection/utils.ts 25 68.71%
Totals Coverage Status
Change from base Build 11107667714: -0.1%
Covered Lines: 5857
Relevant Lines: 11047

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 35a4527 into master Sep 30, 2024
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/lw-header-improvements branch September 30, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants