Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load LW collections separetely from their items #3200

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR does a couple of things, fixing some bugs of the LW initiative, but the most relevant fix is the one that allows the LW collection detail page to load the collection independently from their items, making the experience better for the user.
There are other fixes included in the PR like:

  • Correcting the conditionals in the Third Party Creation Modal so that if a numeric conditional is false, it doesn't show a number instead of showing nothing.
  • The go-back button when you loaded the LW collection by link, now redirects to the LW section of the Collections Page.
  • The Network Icon in the ThirdPartyImage has the correct z-index, removing the overlapping that occurred with the navbar menu.

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 7:01pm

@coveralls
Copy link

coveralls commented Oct 3, 2024

Pull Request Test Coverage Report for Build 11167966109

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 49.013%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routing/locations.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 11167962071: -0.01%
Covered Lines: 5944
Relevant Lines: 11162

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 8c3a394 into master Oct 3, 2024
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/lw-collection-and-item-loader branch October 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants