Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add programmatic selection for linked wearables #3205

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio commented Oct 7, 2024

This PR adds the programmatic selection and publishing for linked wearables.
In order to review the PR, the following must be considered:

  • Linked Wearable collections are set as programmatic when the user uploads files using the multiple file uploader, before having the collection published, and selects the programmatic setting for the collection.
  • Programmatic third parties are created at the time of publishing, so the saga to publish the third parties collections must be aware of it. The isProgrammatic property is used to choose wether the third party is programmatic or not. Programmatic third parties must be created with the minimum of slots (or greater) that a programmatic third party needs.
  • The publication on programmatic third parties is payed only once. Further publications must be shown as "Already payed".
  • Curators must know if a third party collection is programmatic or not, so now there's a badge to identify them.
  • The CreateAndEditMultipleItemsModal had to be converted to functional components to make use of the hook to fetch the price for the standard and programmatic third party selector, as the text include the prices of both types.

Closes #3203

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 6:55pm

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11241826090

Details

  • 23 of 24 (95.83%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 49.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/api/builder.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 11227590741: 0.09%
Covered Lines: 5981
Relevant Lines: 11227

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit ecd9823 into master Oct 8, 2024
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-programmatic-selection branch October 8, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the third party programmatic selector
3 participants