feat: add Store schema #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
force-pushed
the
feat/marketplace-store
branch
from
76c247b
to
ded3273
Compare
cazala
force-pushed
the
feat/marketplace-store
branch
from
ded3273
to
e059305
Compare
fzavalia
reviewed
Nov 25, 2021
package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "lint": "eslint . --ext .ts", | |||
| "lint:fix": "eslint . --ext .ts --fix", | |||
| "check-api": "api-extractor run --typescript-compiler-folder ./node_modules/typescript", | |||
There was a problem hiding this comment.
Maybe check-api would benefit from running build first such as refresh-api
fzavalia
reviewed
Nov 25, 2021
| import { generateValidator, JSONSchema, ValidateFunction } from '../validation' | ||
|
|
||
| export type Store = { | ||
| id: string // urn |
There was a problem hiding this comment.
Not necessary for now, but it would be nice to have urns validated in the schema
There was a problem hiding this comment.
Just daydreaming but for example we could even add utilities like store.id[3] to get that section of the urn if necessary or something like a tree to navigate through different hierarchies. dunno 😂
There was a problem hiding this comment.
yep, tho I dunno how to do that with json schema tbh 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Storeschema