Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bid address and marketplace address to schema #34

Merged
merged 3 commits into from
Dec 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions report/schemas.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export namespace AvatarInfo {
// @public (undocumented)
export type Bid = {
id: string;
bidAddress: string;
bidder: string;
seller: string;
price: string;
Expand Down Expand Up @@ -125,6 +126,7 @@ export type BidFilters = {
first?: number;
skip?: number;
sortBy?: BidSortBy;
bidAddress?: string;
bidder?: string;
seller?: string;
contractAddress?: string;
Expand Down Expand Up @@ -732,6 +734,7 @@ export enum NFTSortBy {
// @public (undocumented)
export type Order = {
id: string;
marketplaceAddress: string;
contractAddress: string;
tokenId: string;
owner: string;
Expand Down Expand Up @@ -760,6 +763,7 @@ export type OrderFilters = {
first?: number;
skip?: number;
sortBy?: OrderSortBy;
marketplaceAddress?: string;
owner?: string;
buyer?: string;
contractAddress?: string;
Expand Down Expand Up @@ -1277,9 +1281,9 @@ export namespace World {

// Warnings were encountered during analysis:
//
// src/dapps/bid.ts:20:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/bid.ts:21:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/bid.ts:39:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/bid.ts:21:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/bid.ts:22:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/bid.ts:41:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/collection.ts:15:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/collection.ts:16:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/collection.ts:36:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
Expand All @@ -1295,9 +1299,9 @@ export namespace World {
// src/dapps/nft.ts:47:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/nft.ts:48:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/nft.ts:71:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/order.ts:17:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/order.ts:18:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/order.ts:30:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/order.ts:18:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/order.ts:19:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/order.ts:32:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/sale.ts:18:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
// src/dapps/sale.ts:19:3 - (ae-incompatible-release-tags) The symbol "chainId" is marked as @public, but its signature references "ChainId" which is marked as @alpha
// src/dapps/sale.ts:42:3 - (ae-incompatible-release-tags) The symbol "network" is marked as @public, but its signature references "Network" which is marked as @alpha
Expand Down
6 changes: 6 additions & 0 deletions src/dapps/bid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Network } from './network'

export type Bid = {
id: string
bidAddress: string
bidder: string
seller: string
price: string
Expand All @@ -31,6 +32,7 @@ export type BidFilters = {
first?: number
skip?: number
sortBy?: BidSortBy
bidAddress?: string
bidder?: string
seller?: string
contractAddress?: string
Expand All @@ -46,6 +48,9 @@ export namespace Bid {
id: {
type: 'string'
},
bidAddress: {
type: 'string'
},
bidder: {
type: 'string'
},
Expand Down Expand Up @@ -85,6 +90,7 @@ export namespace Bid {
},
required: [
'id',
'bidAddress',
'bidder',
'seller',
'price',
Expand Down
6 changes: 6 additions & 0 deletions src/dapps/order.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Network } from './network'

export type Order = {
id: string
marketplaceAddress: string
contractAddress: string
tokenId: string
owner: string
Expand All @@ -22,6 +23,7 @@ export type OrderFilters = {
first?: number
skip?: number
sortBy?: OrderSortBy
marketplaceAddress?: string
owner?: string
buyer?: string
contractAddress?: string
Expand All @@ -43,6 +45,9 @@ export namespace Order {
id: {
type: 'string'
},
marketplaceAddress: {
type: 'string'
},
contractAddress: {
type: 'string'
},
Expand Down Expand Up @@ -74,6 +79,7 @@ export namespace Order {
},
required: [
'id',
'marketplaceAddress',
'contractAddress',
'tokenId',
'owner',
Expand Down
1 change: 1 addition & 0 deletions test/bid.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { testTypeSignature } from './test-utils'
describe('Bid tests', () => {
const bid: Bid = {
id: '0xf87e31492faf9a91b02ee0deaad50d51d56d5d4d-2041694201525630780780247644590609268611-0xc3e43a67c0b9505a690dd80491cf7bf6a3dc26e6',
bidAddress: '0x2041694201525630780780247644590609268611',
bidder: '0xc3e43a67c0b9505a690dd80491cf7bf6a3dc26e6',
seller: '0x81e4fb0c64bf49f89b57f6648562fc9a791b2e92',
price: '5000000000000000000000',
Expand Down
1 change: 1 addition & 0 deletions test/order.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { testTypeSignature } from './test-utils'
describe('Order tests', () => {
const order: Order = {
id: '0x4b20989f296d2a357fe903d155d4302da25e36c91d164d98a85a6ee9a1c88e43',
marketplaceAddress: '0x3041694201525630780780247644590609268596',
contractAddress: '0xf87e31492faf9a91b02ee0deaad50d51d56d5d4d',
tokenId: '2041694201525630780780247644590609268596',
owner: '0x09217b071268aa902f7287f78b16fe84cccbbc43',
Expand Down