Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace Key DID with Peer DID in example to avoid emoji rendering issue #100

Merged
merged 1 commit into from
Jan 8, 2024
Merged

chore: replace Key DID with Peer DID in example to avoid emoji rendering issue #100

merged 1 commit into from
Jan 8, 2024

Conversation

nickreynolds
Copy link
Contributor

  • there have been a few previous attempts to fix this rendering issue, but seems like they have not succeeded
  • I don't think it's worth the effort to track down the rendering issue when we should be able to avoid it by using did:peer instead of did:key in examples
  • if desired, I can change this in other places too, just wanted to put this up for feedback before I go through the rest of the docs

@nickreynolds
chore: replace Key DID with Peer DID in example to avoid emoji render…
7c1b543 
…ing issue

Signed-off-by: nickreynolds <nicholas.s.reynolds@gmail.com>
@rodolfomiranda
Copy link
Contributor

Nice solution (or workaround)!

@TelegramSam TelegramSam merged commit cf9df6a into decentralized-identity:main Jan 8, 2024
1 check failed
@TelegramSam
Copy link
Collaborator

Discussed WG 20240108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickreynolds @rodolfomiranda @TelegramSam