Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar module display improvements #11

Merged
merged 4 commits into from
May 10, 2024

Conversation

ElviaBth
Copy link
Collaborator

@ElviaBth ElviaBth commented May 9, 2024

🎩 What? Why?
Two issues came up during calendar testing on https://wedecide.green.ca/calendar.

  • Times on the calendar are displayed in 24 hour format even when system preference is for am/pm format.

  • Responsive CSS framework is currently working for small screens, as per the 'month view'.

📌 Related Issues
#176 on gpc-decidim

📷 Screenshots

Sets the height of the view

image
Get a am/pm format

♥️ Thank you!

@ElviaBth ElviaBth changed the base branch from main to release/0.27-stable May 9, 2024 10:52
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/0.27-stable@6f81bf7). Click here to learn what that means.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             release/0.27-stable      #11   +/-   ##
======================================================
  Coverage                       ?   91.96%           
======================================================
  Files                          ?       24           
  Lines                          ?      386           
  Branches                       ?        0           
======================================================
  Hits                           ?      355           
  Misses                         ?       31           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElviaBth ElviaBth marked this pull request as ready for review May 10, 2024 10:19
Copy link

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Elvia, let's do a bit of cleaning and that's it!

app/presenters/decidim/calendar/event_presenter.rb Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@microstudi microstudi merged commit 0f0f9b4 into release/0.27-stable May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants