Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

highlight code: Ubuntu window #623

Closed
1 task done
peterpeterparker opened this issue Feb 15, 2020 · 0 comments · Fixed by #632
Closed
1 task done

highlight code: Ubuntu window #623

peterpeterparker opened this issue Feb 15, 2020 · 0 comments · Fixed by #632
Assignees
@peterpeterparker
Labels
enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component
Milestone
studio-beta.12

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Feb 15, 2020 •
edited
Loading

Affected part of DeckDeckGo

  • Web Components

Feature Description

The Web Component highlight-code displays the code in a stylish Mac-window like.

Cody Pearce displayed on Dev.to how to create a stylish Ubuntu-window.

Maybe we could enhance the boolean option of the component to display the code in Mac-window or not to an option to display either Mac-Window, Ubuntu-window or none.

Something like:

@Prop({reflectToAttr: true})
terminal: 'carbon' | 'ubuntu' | 'none' = 'carbon';

Screenshot

Capture d’écran 2020-02-15 à 08 44 52
@peterpeterparker peterpeterparker added enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component labels Feb 15, 2020
@peterpeterparker peterpeterparker self-assigned this Feb 23, 2020
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): code highlight - ubuntu terminal
dfa0bd6 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
@peterpeterparker peterpeterparker linked a pull request Feb 23, 2020 that will close this issue
feat(#623): code highlight - ubuntu terminal #632
Merged
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): ignore prettier
3d9567a 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): test terminal none
32abb38 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): ignore prettier
3d08b91 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): add Cory McArthur's handy injectCSS and injectJS function…
a27c6ea 
…s to utils

Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
release(#623): utils v1.0.0-rc.3
a560fba 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): ubuntu background and font
0bfca13 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
@peterpeterparker peterpeterparker added this to the studio-beta.12 milestone Feb 23, 2020
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
release(#623): highlight-code v1.0.0-rc.3
3fc39a4 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
fix(#623): CSS variable misspelled
343d04c 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): require @deckdeckgo/utils rc.3
87922a6 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
release(#623): highlight-code v1.0.0-rc.3-1
5669336 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): document new highlight-code terminal Ubuntu
4de8976 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
fix(#623): CSS typo
5c79462 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
release(#623): highlight-code v1.0.0-rc.3-2
6d65db1 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
feat(#623): install last highlight-code
fc20ee8 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
release(#623): docs v1.0.0-rc.10-1
3fe36be 
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker added a commit that referenced this issue Feb 23, 2020
@peterpeterparker
Merge pull request #632 from deckgo/code-terminal-ubuntu
f24a308 
feat(#623): code highlight - ubuntu terminal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterpeterparker peterpeterparker

Labels
enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component
Projects
None yet
Milestone
studio-beta.12
Development

Successfully merging a pull request may close this issue.

feat(#623): code highlight - ubuntu terminal deckgo/deckdeckgo
1 participant
@peterpeterparker