Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for searching by productId on productList loader #46

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

ingridflack
Copy link
Contributor

Description

This PR aims to add support for searching by productId on the productList loader by adding 2 new props while keeping backward compatibility with the ids prop.

Changes

  • Add skus and productIds props that will have the data for each type of search
  • The ids prop fallbacks to the same behavior as skus to be backward compatible
  • Add a helper function to avoid code duplication

Test instructions

  • Test using ids or skus, should return a list of skus;
  • Test using productIds should return a list of products;
  • Other behaviors should stay the same.

@lucis lucis merged commit 6ab3874 into deco-cx:main Sep 13, 2023
1 check passed
vitoUwu pushed a commit to vitoUwu/deco-cx-apps that referenced this pull request Feb 12, 2024
)

* Added search by product id on productList loader

* Remove skus from props, fix interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants