Everything needed to run simple Rust programs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethteck
approved these changes
Sep 9, 2023
jpburnett
reviewed
Sep 9, 2023
|
|
||
| using random_bytes_engine = std::independent_bits_engine<std::default_random_engine, CHAR_BIT, unsigned char>; | ||
|
|
||
| NTSTATUS WIN_FUNC BCryptGenRandom(BCRYPT_ALG_HANDLE hAlgorithm, PUCHAR pbBuffer, ULONG cbBuffer, ULONG dwFlags) { |
There was a problem hiding this comment.
Rust's HashMap uses random bytes as a seed. It's not actually using a BCrypt hash, but the BCryptGenRandom function is a good place to get random bytes, apparently.
jpburnett
approved these changes
Sep 9, 2023
| if (nSize < len) { | ||
| return len; | ||
| } | ||
| const uint16_t *wideValue = stringToWideString(value); |
There was a problem hiding this comment.
memory leak; should we maybe add a version of stringToWideString that returns a vector<uint16_t>?
There was a problem hiding this comment.
Agreed, or maybe std::wstring? Added a free() for now
There was a problem hiding this comment.
wstring is UTF-32 on Linux, alas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to support running sjiswrap for
mwcceppc.exe.Of note:
LoadLibraryA,GetModuleHandleA,GetProcAddress, etc..clang-formatand.clang-tidyfor editors.NtAllocateVirtualMemoryandNtProtectVirtualMemoryare fun, they're forsjiswrapto map the sub-subprocess and execute it. Wrapper inception!