Commits on Oct 26, 2023

1. Handle dwCreationDisposition in CreateFileA to fix PSYLINK …

   Before this change, dwCreationDisposition parameter of CreateFileA was
   ignored by wibo. However, it turns out that PSYLINK.EXE in PsyQ 4.4
   sometimes depends on correct handling of that parameter.
   
   When building overlays with PSYLINK.EXE, it sometimes opens the
   resulting overlay file the second time, with OPEN_EXISTING creation
   disposition (as opposed to TRUNCATE_EXISTING). Before the change,
   wibo opened that file with fopen(..., "wb+") which truncated the file
   even though OPEN_EXISTING (non-truncating) was requested. This affected
   https://github.com/foxdieteam/mgs_reversing, where one of the overlays
   (camera.bin) was built incorrectly when using wibo (worked correctly
   on Windows or with wine).
   
   This commit adds proper handling of dwCreationDisposition parameter.
   The file now can be opened in truncating or non-truncating mode.
   Additionally, the implementation now reacts correctly to file
   existing/non-existing as specified by the requested creation disposition
   mode. For example, if CreateFileA is called with OPEN_EXISTING and the
   file does not exist it will set an error and not create a new file
   (the previous behavior). If the file exists, it's opened in
   non-truncating mode, as TRUNCATE_EXISTING or CREATE_ALWAYS is required
   for truncation.
   
   After the fix you can correctly build the whole mgs_reversing project
   with wibo - tools running under wibo: ASMPSX, ASPSX, CC1PSX 4.0 & 4.4,
   PSYLINK. I have NOT tested other executables apart from those.

   

   nocato committed Oct 26, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for bb53c52
   • Browse repository at this point

   Copy the full SHA

   bb53c52 View commit details

   Browse the repository at this point in the history