multi: Change NoSplitTransaction param to SplitTx. #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
split_tx
branch
2 times, most recently
from
532b511
to
52c12e2
Compare
dnldd
changed the title
davecgh
requested changes
May 27, 2018
rpcclient/wallet.go
Outdated
| cmd := dcrjson.NewPurchaseTicketCmd(fromAccount, spendLimit.ToCoin(), | ||
| &minConfVal, &ticketAddrStr, &numTicketsVal, &poolAddrStr, | ||
| &poolFeesFloat, &expiryVal, nil, noSplitTransaction, &ticketFeeFloat) | ||
| &poolFeesFloat, &expiryVal, dcrjson.String(""), &splitTxVal, &ticketFeeFloat) |
There was a problem hiding this comment.
No need to allocate:
dcrjson.String("") -> nil
There was a problem hiding this comment.
This was actually a necessary change since the arguments that follow a nil pointer will not be processed. The workaround is to have a non-nil pointer to an empty string.
The SplitTx parameter for PurchaseTicketCmd specifies theminimumnumberof inputs needed to use a split transaction for aticketpurchase. Theparameter options are 1 and 2. Ticket purchaseinputsless than the setSplitTx value are used directly in thetransaction.
davecgh
approved these changes
May 27, 2018
|
The In general, this seems to be a gotcha that comes up a lot. e.g. decred/dcrrpcclient#89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SplitTx parameter for PurchaseTicketCmd specifies the minimum
number of inputs needed to use a split transaction for a ticket
purchase. The parameter options are 1 and 2. Ticket purchase inputs
less than the set SplitTx value are used directly in the transaction.